I'm upgrading from a Drupal 6 site to Drupal 7, and I noticed that the format column in better_formats_default table is still an int, not a varchar. Filter formats now have a machine name, not an int identifier. If that wasn't terrifying enough, I noticed that there isn't even a hook_schema declaration for this table in the install file for 7, and there are db_fetch_object() calls to the non-existent table all throughout better_formats.admin_defaults.git. db_fetch_object no longer exists in 7. Yikes!

Can someone shed light on this? Is the database table no longer necessary? Is the admin.defaults.inc not being used? If so, there should be a hook_update_N to delete the table, and that file should be deleted from the repository.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dragonwize’s picture

Category: bug » support
Status: Active » Fixed

Sounds like you have a lot of old stuff lying around. I would suggest uninstalling the module and re-installing. BF in D7 is very different from in D6 and does not carry over.

I will write migration docs with the rest when get to the rest of the new docs.

q0rban’s picture

This is a clean download of the module from drupal.org. I'm looking at the actual repository on drupal.org:

//drupalcode.org/project/better_formats.git/blob/refs/heads/7.x-1.x:/better_formats.admin_defaults.inc

//drupalcode.org/project/better_formats.git/blob/refs/heads/7.x-1.x:/better_formats.install

dragonwize’s picture

Category: bug » support
Status: Active » Fixed

As you can see, it is intended but not complete as the module is not complete. As I said before, I will write the docs on it later but it will essentially just delete you data as it is not usable in the new system.

So my suggestion to you was that if you want to do it now then just uninstall the module before upgrading and it will basically be the same.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.