We moved the lock API to a PSR-0 class + procedural factory, and left the lock_*() functions in as a bc layer, but then never opened the follow-up issue to remove them, so here it is.

Need to:

- convert core to use lock()->$foo() instead of lock_*()

- remove all the lock_*() functions from lock.inc

- move lock() to bootstrap.inc

- git rm core/includes/lock.inc

CommentFileSizeAuthor
#3 lock-bc-1774134-3.patch21.38 KBamateescu
#1 lock-bc-1774134-1.patch20.37 KBlarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Active » Needs review
FileSize
lock-bc-1774134-1.patch20.37 KB

first crack

Status: Needs review » Needs work

The last submitted patch, lock-bc-1774134-1.patch, failed testing.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs work » Needs review
FileSize
lock-bc-1774134-3.patch21.38 KB

I was working on this as well :) Let's try this one.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented

meh, missed the 

require_once DRUPAL_ROOT . '/core/includes/lock.inc';

calls

rbayliss’s picture

rbayliss CreditAttribution: rbayliss commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Patch applies, passes tests, and doesn't introduce any new functionality.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Great. Committed/pushed to 8.x.

I opened #1786460: Add the lock API to the DIC as a follow-up and updated the change notification at http://drupal.org/node/1525118, so moving this straight to fixed.

Automatically closed -- issue fixed for 2 weeks with no activity.