Reproduce:

  1. Create a term with an ampersand (&).
  2. Create a panel (for example) such that this term name is sent to a view as an argument.
  3. Create a view that receives the term name as a Contextual Filter, provides a Validation criteria of type Taxonomy term, and uses Filter type Term name converted to term id.

The terms with an ampersand will not be properly converted, thus resulting in an empty view.

Files: 
CommentFileSizeAuthor
#18 views-ampersand_in_contextual_filter-1768738-12.patch941 byteslmeurs
#13 views-ampersand_in_contextual_filter-1768738-12.patch941 byteslmeurs
Test request sent.
[ View ]
#6 views-term_arg_decode_entities-1768738-6.patch726 bytesjeffschuler
PASSED: [[SimpleTest]]: [MySQL] 1,555 pass(es).
[ View ]
#2 term-decode.patch545 byteseckroth
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch term-decode_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
term-decode.patch515 byteseckroth
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch term-decode.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Status:Needs review» Needs work

The last submitted patch, term-decode.patch, failed testing.

eckroth’s picture

StatusFileSize
new545 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch term-decode_0.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
eckroth’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, term-decode.patch, failed testing.

eckroth’s picture

I'll read up on how to format a patch later... it's a one-liner so it should be easily understood even without automated testing.

jeffschuler’s picture

Version:7.x-3.5» 7.x-3.x-dev
Priority:Major» Normal
Status:Needs work» Needs review
StatusFileSize
new726 bytes
PASSED: [[SimpleTest]]: [MySQL] 1,555 pass(es).
[ View ]

Looks like your patch is missing another newline at the end.
I could apply it using the patch utility, but not with git apply.
Rerolled

freak1321’s picture

omerida’s picture

this patch fixed this issue for me

Geijutsuka’s picture

Is this issue related to #672606: Hyphens and forward slashes (-/) break Views contextual filters? It would be great if this patch killed two issues.

Edit: sorry, didn't mean to reference the same issue...

sgammon’s picture

Just curious, will this patch be in the next Views release?

meeli’s picture

If you select the option to convert spaces in term names to hyphens this patch is no longer effective. Investigating this now, I'll post a patch if I can figure it out.

jyraya’s picture

Issue summary:View changes

Hello meeli,

Selecting option "convert spaces in term names to hyphens" did not work for me when I pass the argument through a views pane context and the passed name come from a term reference field value. The ampersand contained in the term name is still "&".

The patch supplied by jeffschuler worked for me (thanks for it!).

I think that the decode_entities should also applied when the the option "convert spaces in term names to hyphens" because of other special characters that could be to convert like "é", "ç", "ô".
Do you see a case where that could not work by applying the decode_entities in this case?

lmeurs’s picture

StatusFileSize
new941 bytes
Test request sent.
[ View ]

Thanks for the patch!

@jyraya, @meeli: I cannot find the option Convert spaces in term names to hyphens, is this in Panels or Views?

I did find the Transform dashes in URL to spaces in term name filter values option in the Views' contextual filter dialog window. The patch from #6 does not take this option into account, it only decodes entities if the transform option has not been set.

Attached patch decodes entities in both cases, please review and set RTBC if all is ok!

afoster’s picture

#13 worked for me. thanks!

RumpledElf’s picture

Status:Needs review» Reviewed & tested by the community

Just hit this myself - I was using a term contextual filter both on a page view and a block on the same page view. This issue only affected the block view and ONLY because it had an exposed filter and did a keyword search via ajax. The search worked fine in preview but not on the actual view page, and the term correctly converted with an ampersand in it to get the base category contextual filter on the block, just not with the ajax exposed filter keyword search.

Patch in #13 also worked for me, count me in as another happy reviewed-and-tested-it community member.

froboy’s picture

I'm having trouble with getting this to work. Could someone who's successfully tested post the term names they've tested with? It seems to me that this still doesn't fix the issue. It looks like it's decoding entities in the argument, but not in the td.name, which is what we need, right? I have terms like "Arts & Humanities" which don't match with the

Playing around with the query, I came up with this:

       if ($transform) {
          $query->where("replace(replace(td.name, ' & ', '-'), ' ', '-') = :name", array(':name' => decode_entities($argument)));
        }

but that seems hacky and probably not valid behavior for every case, maybe? What I (we?) really need is to totally clean the string like in pathauto_cleanstring or ctools_cleanstring and at that point using merlinofchaos's advice is probably simpler (and what I'll most likely do). Can someone give me a sanity check here? If it looks valid, I can set it up for both cases and submit a new patch.
colan’s picture

We've recently switched our testing from the old qa.drupal.org to DrupalCI. Because of a bug in the new system, #2623840: Views (D7) patches not being tested, older patches must be re-uploaded. On re-uploading the patch, please set the status to "Needs Review" so that the test bot will add it to its queue.

If all tests pass, change the Status back to "Reviewed & tested by the community". We'll most likely commit the patch immediately without having to go through another round of peer review.

We apologize for the trouble, and appreciate your patience.

lmeurs’s picture

Re-uploading the patch from #13.

lmeurs’s picture

Status:Needs review» Reviewed & tested by the community

Set status back to RTBC according to the request in #17.