Some are grouped wrong or not at all, and ViewsSqlTest is misnamed.

CommentFileSizeAuthor
#9 views-1760586-9.patch74.59 KBtim.plunkett
#5 views-1760586-5.patch74.98 KBtim.plunkett
#3 views-1760586-3.patch74.53 KBtim.plunkett
#1 views-1760586-1.patch74.53 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: Unassigned » tim.plunkett
Status: Active » Needs review
Issue tags: +VDC
FileSize
views-1760586-1.patch74.53 KB

See attached.

I have a branch for this, so I'll be merging it in when RTBC.

Status: Needs review » Needs work

The last submitted patch, views-1760586-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
views-1760586-3.patch74.53 KB

CTools was using my old class name.

Status: Needs review » Needs work

The last submitted patch, views-1760586-3.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
views-1760586-5.patch74.98 KB

There was some trickiness in the Comment tests. I really hope this runs now, or we're going to have CTools issues.

Status: Needs review » Needs work
Issue tags: -VDC

The last submitted patch, views-1760586-5.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review

#5: views-1760586-5.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, views-1760586-5.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
views-1760586-9.patch74.59 KB

I hate the Comment tests. But now they pass locally now.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

A few todo's left on the new base test classes. But I would merge it in as it is now.

Incremental progress++

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Fixed

This has been committed.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

This already got committed.

Automatically closed -- issue fixed for 2 weeks with no activity.