Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bellesmanieres’s picture

Assigned: Unassigned » bellesmanieres
bellesmanieres’s picture

Status: Active » Needs review
FileSize
2.61 KB

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 1756656-uses_grouping_to_property-2.patch, failed testing.

bellesmanieres’s picture

Rerolled against latest code.

dawehner’s picture

+++ b/lib/Drupal/views/Plugin/views/style/StylePluginBase.phpundefined
@@ -224,10 +237,9 @@ abstract class StylePluginBase extends PluginBase {
+    // themselves from being groupable by setting their "usesGrouping" property to FALSE.

We got forced to be hard :) This goes over 80 chars...

bellesmanieres’s picture

Doh, must check my IDE settings, it's supposed to warn me about that !

bellesmanieres’s picture

Status: Needs work » Needs review
dawehner’s picture

Status: Needs review » Fixed

Perfect.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.