Once the dependency patch is in, it'll be a huge win to reduce jQuery dependency on some scripts.

Meaning putting the freezeHeight in ajax.js where it's used.
The tricky part is the content ready call. we'll either have to move or replace it. I can see a separate file with only this call and a dependency on jQuery for the small file. It'll be easy for someone to just swap it out and use something else if possible.

#9 core-js-remove-jQuery-drupaljs-1751584-9.patch5.41 KBseutje
PASSED: [[SimpleTest]]: [MySQL] 42,303 pass(es). View
#9 core-js-remove-jQuery-drupaljs-1751584-9-interdiff.txt769 bytesseutje
#3 core-js-remove-jQuery-drupaljs-1751584-3.patch4.66 KBnod_
FAILED: [[SimpleTest]]: [MySQL] 41,487 pass(es), 1 fail(s), and 0 exception(s). View
Members fund testing for the Drupal project. Drupal Association Learn more


nod_’s picture

Status: Active » Postponed
nod_’s picture

Status: Postponed » Active

Patch is in, making this happen could be a huge win now.

nod_’s picture

Status: Active » Needs review
4.66 KB
FAILED: [[SimpleTest]]: [MySQL] 41,487 pass(es), 1 fail(s), and 0 exception(s). View

Moving freezeheight and adding a ~450b of minified+gziped JS to handle domready using this: https://github.com/ded/domready

This patch removes the noConflict mode of jQuery since I don't know where that should be now that we don't depend on it for drupal.js This is NW but putting as NR to get some opinions.

nod_’s picture

Issue tags: +mobile


Status: Needs review » Needs work

The last submitted patch, core-js-remove-jQuery-drupaljs-1751584-3.patch, failed testing.

nod_’s picture

Compared a few runs, this patch benefits more significantly IE9 than Firefox, that's interesting. Anyway, data backs-up that this is a perf improvment even if jQuery is still needed in other parts of the admin.

nod_’s picture

Status: Needs work » Needs review

Let's deal with the error later, just want opinions on the thing for now.

Jelle_S’s picture

Patch looks pretty sane to me. Not sure what causes the error though?

seutje’s picture

769 bytes
5.41 KB
PASSED: [[SimpleTest]]: [MySQL] 42,303 pass(es). View

The test that failed assumes that any call to drupal_add_js that adds inline JavaScript, also adds jQuery.

Modified the test to also add jQuery.

Not sure if this is the proper approach, but it makes sense to me that inline JavaScript would need to define its dependency on jQuery, without turning the inline JavaScript into a "library" with a dependency.

nod_’s picture

Status: Needs review » Closed (duplicate)