Part of the JavaScript selectors clean-up effort.
#1574470: Selectors clean-up
#1415788: Javascript winter clean-up

CommentFileSizeAuthor
#6 1751394-local-js.patch1.09 KBdroplet
#3 locale.patch2.78 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented

try to see if Drupal.t() can be replaced by t() or drupalt() or something that is not an object in the regex pickingup strings from JS files. This is terrible to minify.

rest should be fine.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Issue tags: +Needs JavaScript testing

tag

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Active » Needs review
FileSize
locale.patch2.78 KB

about Drupal.t,

Yeah, it's a bit terrible. however after gzip, it's not much different.

droplet’s picture

droplet CreditAttribution: droplet commented

3: locale.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: locale.patch, failed testing.

droplet’s picture

droplet CreditAttribution: droplet commented
Issue summary: View changes
Status: Needs work » Needs review
FileSize
1751394-local-js.patch1.09 KB

This issue could "close as won't fix" now. the attached patch only make it looks more consistent to other JS in Drupal

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Needs review » Reviewed & tested by the community

Trivial but works and does increase consistency so it's fine :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.