Field (set) group label can be translated, but not the description?

Steps:
Install i18n, field_group field translation. Enable a second language (e.g. FR),
- enable multi.language for the article content type, add a field set and give it a label and description
- go to admin/config/regional/translate/translate and search for the label and description entered above.
- add an example text field within the field set and translate the field
- the field label/description can be translated fine
- whereas the fieldset label can be found and translated, but not the description cannot

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Stalski’s picture

Status: Active » Closed (won't fix)

Some great work has been done here: http://drupal.org/sandbox/webflo/1413404. This will be the lead for the field_group integration on internationalization.
For this reason the t() is not used (anymore, would need to check) for labels and description. It is content in our opinion and thus of i18n_field_group.

Webflo has done some excellent work on that, just waiting on a release for it.

boran’s picture

Thanks, but that sandbox is empty?

Stalski’s picture

Pere Orga’s picture

I see that this is still not committed to 7.x-1.x-dev

Does anyone know if it will be at some point?

Cheers

Stalski’s picture

This is not a commit on this module.

Stalski’s picture

Pere Orga’s picture

Good to see a solution for this.
But is there any particular reason for having this in a different module?

And what is the difference between http://drupal.org/sandbox/webflo/1413404 and http://drupal.org/sandbox/opin/1762478 ? The two look inactive.

Pere Orga’s picture

Status: Closed (won't fix) » Needs work

In my opinion this should be solved in this module and not in a separate one.

ovide’s picture

FileSize
3.31 KB
caktux’s picture

Status: Needs work » Needs review
FileSize
1.61 KB

Here's a git patch...

geek-merlin’s picture

Status: Needs review » Needs work

This needs work.
* patches in #9 and #10 use t() which is not the way string translation should work (i18n assigns IDs to non-code strings so translations stick when source is changed)
* reviewed the 2 sandbox modules and code in https://drupal.org/sandbox/webflo/1413404 looks better to me

@Stalski: i also think this should live in field_group.module, would you as maintainer accept a patch that incorporates webflo's sandbox (with a namespace change) as a submodule?

Stalski’s picture

Hi,

It could still go in for D7. Let's start from the sandbox of webflo and sync with him about this decision. I think he'll be happy.

So let's create a patch. There are some todo's in the code, so if someone is willing to make the final patch, let's have it :)

Georgique’s picture

FileSize
685 bytes

Isn't description translated in field_group_pre_render_prepare()?
I believe it is, also it should be improved because there might be case when we translate empty string.
Patch is attached.

Georgique’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, field_group.patch, failed testing.

mibfire’s picture

Issue summary: View changes

https://drupal.org/sandbox/webflo/1413404 This module doesnt work on Commerce checkout pages. See: https://www.drupal.org/node/2368837

Georgique’s picture

Status: Needs work » Needs review
FileSize
1.04 KB

Let's try this patch...

giupenni’s picture

I have to apply either the patch # 9 and # 10 to test?

bramvandenbulcke’s picture

I'm using the latest version of Field Group, version 1.5 and it's possible to translate the description of a field group. The strange thing is it doesn't show up easily in the translate tab (/admin/config/regional/translate/translate). I ran cron and cache clear 10 times and did string refresh 3 times (/admin/config/regional/translate/i18n_string, but the string didn't show up on the translate tab. But after creating a node of that type, it did!

Hopefully this offers some help to others with the same problem.

Fabioc79’s picture

I spent half a day without being able to see field group labels/descriptions in the traslate page (/admin/config/regional/translate/translate). Finally I got the solution and I share it.

To make strings appear in the translation interface, you have to visit the page where those strings are printed IN THE LANGAUGE YOU WANT TO TRANSLATE (not in the default source language).

I hope this can help someone.

Chris Matthews’s picture

The 4 year old patch in #17 to field_group.module applied cleanly to the latest field_group 7.x-1.x-dev, but still needs review (if still applicable).

julien.reulos’s picture

I can translate field_group descriptions with version 1.6, no need for this patch. This issue should be closed as Fixed.

Anybody’s picture