Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I've attached a patch that fixes my problem with backups having an empty database.sql file, which was due to having a '#' character in the password. Using double quotes (") fixes that issue for me, and if you text-search this page: http://dev.mysql.com/doc/refman/5.5/en/option-files.html for "password" I think you will find that this is the recommended way to set the password in my.cnf.
It's annoying that the proc_close return is 0 even though the mysqldump command should definitely be returning non-zero when I get the password wrong. I have yet to actually test that mysqldump behaves in this way with file descriptor passing of a defaults-file. If it is returning non-zero and proc_close() is just getting it wrong, then I am not sure what we can do about it without having access to the pcntl extension.
To find out if this patch would fix your problem, configure the drupal site to use an alphanumeric password and invoke provision-migrate.
| Comment | File | Size | Author |
|---|---|---|---|
| issue1324466_19.patch | 400 bytes | wamilton |
Comments
Comment #1
Steven Jones CreditAttribution: Steven Jones commentedAh sweet! Thanks so much more the patch! Reviewing...
Comment #2
Steven Jones CreditAttribution: Steven Jones commentedSorry, I can't review this at the moment at Drupalcon, because the internet connection is just too slow, I'll review later.
Comment #3
Steven Jones CreditAttribution: Steven Jones commentedTested and this does indeed fix this issue, thanks for waiting and thanks very much for the patch!
Comment #4
Steven Jones CreditAttribution: Steven Jones commentedCommitted to 6.x-1.x and 6.x-2.x. Thanks again!