Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
instead of
The field I have read and accepted the T&C is required
or
The field Street and Nr. is required
use
The field 'I have read and accepted the T&C' is required
or
The field 'Street and Nr.' is required
I know this can be easily changed with the translation tool, but I think this is a kind of 'user friendlyness' issue and therefore should be put in core.
Comment | File | Size | Author |
---|---|---|---|
#3 | quote-field-name-1738210-3.patch | 14.05 KB | larowlan |
#1 | quote-field-name-1738210-1.patch | 706 bytes | larowlan |
Comments
Comment #1
larowlanComment #3
larowlanAgain with tests updated.
Comment #4
Nikdilis CreditAttribution: Nikdilis commented@larowlan: Wow, that was fast. Thank you very much.
Let's get it reviewed and ready to be committed.
Comment #5
larowlan@Nikdilis - does that mean you're reviewing it?
Comment #6
larowlanTagging
Comment #7
BarisW CreditAttribution: BarisW commentedJust to be sure, do we want quotes around field names? Why not just use % to mark them italic?
What's better?
- The field 'Street and Nr.' is required
- The field Street and Nr. is required
Comment #8
larowlanYeah considered that too, 6 one, half-dozen the other.
Comment #9
aboros CreditAttribution: aboros commentedis this one still an issue?
i was about to review the patch, but then discovered that the response from drupal changed quite a lot. currently as i am submitting a node form while leaving some required fields empty, instead of the regular drupal message i see a nice 'inline popup', so i cannot see the problem described in the issue. this is what i see: https://skitch.com/aboros/epud7/create-article-d8.local
Comment #10
Nikdilis CreditAttribution: Nikdilis commentedok, it seems that the way errors are shown has changed in Drupal8. Now a
<abbr></abbr>
tag is used in a way as shown in #9. When I tested it on a new installation of Drupal 8 however, the error moved around while scrolling. Can anyone confirm that?Regarding to #1-#8: I think it is no longer an issue.
Comment #11
Nikdilis CreditAttribution: Nikdilis commentedCan anyone confirm #10? Thanks.
Comment #11.0
Nikdilis CreditAttribution: Nikdilis commentedna