The docs here:

http://api.drupal.org/api/views/includes%21view.inc/function/view%3A%3Ae...

say

Return value

bool Return whether the executing was successful, for example an argument could stop the process.

but there are paths through that function that give no return value.

CommentFileSizeAuthor
#4 1729896.patch260 bytesdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Title: view::execute() return value - incorrect docs » view::execute() return value - incorrect function

What about this title change?

crantok’s picture

crantok CreditAttribution: crantok commented

I like the change in perspective :)

crantok’s picture

crantok CreditAttribution: crantok commented
Component: Documentation » Code
damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Active » Needs review
FileSize
1729896.patch260 bytes

Wont returning TRUE at the end of the function if/when it gets there cover us?

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented
Version: 7.x-3.3 » 7.x-3.x-dev
Issue summary: View changes

The 6 year old patch in #4 applied cleanly to the latest views 7.x-3.x-dev and if still applicable needs review.

Checking patch includes/view.inc...
Hunk #1 succeeded at 1214 (offset 48 lines).
Applied patch includes/view.inc cleanly.