The attached patch cleans up numerous code style issues identified by coder for the core modules directory.

CommentFileSizeAuthor
#6 codestyle2_1.patch1.95 KBwebernet
#4 codestyle2_0.patch23.03 KBwebernet
codestyle2.patch23.04 KBwebernet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

webernet’s picture

webernet CreditAttribution: webernet commented
Title: * ViewCode Style Cleanup: Core modules directory » Code Style Cleanup: Core modules directory
hass’s picture

hass CreditAttribution: hass commented

Code changes looks correct. Isn't bad code style not a bug!?

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Looks good indeed.

webernet’s picture

webernet CreditAttribution: webernet commented
FileSize
codestyle2_0.patch23.03 KB

Rerolled for whitespace changes to comment module that went in with http://drupal.org/node/172950

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Needs work

This patch didn't apply cleanly, but I've committed the parts that did. We'll want to re-roll what was left out. Therefore, I'm marking this 'code needs work'. :)

webernet’s picture

webernet CreditAttribution: webernet commented
Status: Needs work » Reviewed & tested by the community
FileSize
codestyle2_1.patch1.95 KB

Rerolled the uncommitted portion for the aggregator split.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)