Files: 
CommentFileSizeAuthor
views_rss-feed-contextual-filters.patch1003 bytesjamix

Comments

  • maciej.zgadzaj committed 90dd31a on 7.x-2.x authored by jamix
    Issue #1722348 by jamix: Contextual filters should not be added to feed...
maciej.zgadzaj’s picture

Issue summary:View changes
Status:Needs review» Fixed

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dman’s picture

Status:Closed (fixed)» Needs work

I think it may have been a mistake to roll in a 3-year-old fix verbatim without tests.
I found that my views that DO use arguments started producing rss links like

/news/%25/rss.xml

Where previously I was getting a term ID in the path.

Tracing deep, and comparing the current "7.x-3.8" Views version (not three-year-old -dev version) of
views_plugin_style_rss::attach_to()
with our
views_rss_plugin_style_fields::attach_to()

Shows that
A: there is no such thing as $this->display->display_options['arguments'] to ever check
B: it seems the logic that may have been needed to ensure "Contextual filters should not be added" has been migrated into $view->get_url() so whatever problem this patched solved no longer exists.

I think this needs to come back out!

To replicate:
Using views_rss 7.x-2.0-rc4 or 7.x-2.x-dev

  1. Create a base view page that takes a contextual argument (eg term tid path: /news/% )
  2. Add a feed, using normal views "RSS Feed" format, inheriting the same contextual filter, ( path /news/%/rss.xml ).
  3. Link the base page to 'Link display" your feed.
  4. Verify that when viewing the main page using a filter (/news/123 ) you get an rss icon link ( /news/123/rss.xml )

= this is correct.

  1. Now switch the feed display to views_rss "RSS Feed - Fields"
  2. Note that when viewing the main page using a filter (/news/123 ) you get an rss icon link ( /news/%25/rss.xml )

= this is wrong.

  1. Roll back the change made here in this issue

= works again.