Voting starts in March for the Drupal Association Board election.
See #1278760: RSS feed icon should not include contextual filters arguments in link if the feed display does not support contextual filters. Attached patch is a verbatim copy of patch from #5 in the original issue.
Issue #1722348 by jamix: Contextual filters should not be added to feed...
Committed and pushed to 7.x-2.x
Automatically closed - issue fixed for 2 weeks with no activity.
I think it may have been a mistake to roll in a 3-year-old fix verbatim without tests.
I found that my views that DO use arguments started producing rss links like
Where previously I was getting a term ID in the path.
Tracing deep, and comparing the current "7.x-3.8" Views version (not three-year-old -dev version) ofviews_plugin_style_rss::attach_to()
A: there is no such thing as $this->display->display_options['arguments'] to ever check
B: it seems the logic that may have been needed to ensure "Contextual filters should not be added" has been migrated into $view->get_url() so whatever problem this patched solved no longer exists.
I think this needs to come back out!
Using views_rss 7.x-2.0-rc4 or 7.x-2.x-dev
= this is correct.
= this is wrong.
= works again.
Agreed with dman, this patch breaks the contextual filter functionality pretty thoroughly. Tracing out the problem has confirmed that the patch here is no longer relevant, and rolling back to before this change fixes the issue.
It seems as though the issue is slightly more complicated. Views RSS (and Date iCal too) relies on contextual filters being passed from the Views displays to which they are attached.
The proposed patch in #1278760 essentially requires feeds to have their own contextual filters, otherwise it won't work as expected. Once #1278760 is included, it is necessary to also have the patch on this thread, and also the similar patch that exists for Date iCal (https://www.drupal.org/node/2791847).
I believe the key question is, should attached feeds be allowed to inherit the contextual filters of the Views displays to which they are attached, or, should feeds (RSS, iCal, etc.) be required to have their own contextual filters, as is being asserted in #1278760?
Drupal is a registered trademark of Dries Buytaert.