Hi,
first of all, I noticed a lot of work has gone into the admin menu API in the recent months (or since last time I checked).
I especially like hook_admin_menu_map(), and the cleanup following that. And all the work that related to #821128: Ensure reliable link structure and contents for alter hooks (to not break on customizations).

I noticed that field_ui_admin_menu_map() has a lot of entity-type-specific code in it, which could be made more generic, to support more entity types, e.g. those defined with Entity API.

Some directions:
* Make use of $bundle_info['real path'], where it is available.
* As a consequence, support the dash instead of underscore for content types configuration pages.
* Get rid of the hardcoded switch() in field_ui_admin_menu_map(), and make it generic instead.
* Aside of field_ui, we can add general support for entity API. E.g. to automatically register those bundle paths.

Patch might follow, but now I'm on the run :)

Comments

donquixote’s picture

donquixote CreditAttribution: donquixote commented
Issue summary: View changes

link to #821128: Ensure reliable link structure and contents for alter hooks (to not break on customizations)

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)
Issue tags: +postponed2w

I am sorry for no reply until now.

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: -postponed2w

This issue has been automatically marked as closed because it has not had recent activity after the last post.

However, if you or someone is still facing the same issue as described to the issue, could you please to re-open the issue by changing the status of the issue, and add an explanation with more details which can help us to reproduce your situation.

Again, thank you for your contributions! :)