iam creating a non-english commerce website. In the checkout, the user can copy their billing information into the shipping information. Thats nice, but the translation uses drupal_strtolower() to make the translation lowercase.
That may be correct in english, but what about other languages? My project uses the german translation and in german, the @target's and @source's first letter has to be uppercase (so the database string version should be directly used without drupal_strtolower()).

I removed the strtolower now in core... works now... until next update... how can we fix this problem?

commerce_customer.checkout_pane.inc Line #129:
'#title' => t('My @target is the same as my @source.', array('@target' => drupal_strtolower($target_profile_type['name']), '@source' => drupal_strtolower($source_profile_type['name']))),

Thank you very much :)

#1 1718958-1.profile_copy_placeholder.patch1.13 KBrszrama
PASSED: [[SimpleTest]]: [MySQL] 3,570 pass(es). View
#1 placeholder-token-profile-copy.png10.27 KBrszrama
Members fund testing for the Drupal project. Drupal Association Learn more


rszrama’s picture

Title: Dont use drupal_strtolower() in the checkout pane translation » Update the profile copy checkbox text to work better internationally
Version: 7.x-1.3 » 7.x-1.x-dev
Category: bug » task
Status: Active » Needs review
Issue tags: +internationalization
10.27 KB
1.13 KB
PASSED: [[SimpleTest]]: [MySQL] 3,570 pass(es). View

What if we changed it to use the % placeholder instead?

krabbe’s picture

Thank you, rszrama. The patch works perfect for me.

star26bsd’s picture

Yepp, this patch works fine for me, thanks rszrama.

rszrama’s picture

Awesome, thanks. I'm not sure why test results aren't being returned; I'll sort that out and get it tested / committed.

rszrama’s picture

Status: Needs review » Fixed

Fixed the failing tests a couple days ago. Just committed this.

Automatically closed -- issue fixed for 2 weeks with no activity.