Hi,
iam creating a non-english commerce website. In the checkout, the user can copy their billing information into the shipping information. Thats nice, but the translation uses drupal_strtolower() to make the translation lowercase.
That may be correct in english, but what about other languages? My project uses the german translation and in german, the @target's and @source's first letter has to be uppercase (so the database string version should be directly used without drupal_strtolower()).
I removed the strtolower now in core... works now... until next update... how can we fix this problem?
commerce_customer.checkout_pane.inc Line #129:
'#title' => t('My @target is the same as my @source.', array('@target' => drupal_strtolower($target_profile_type['name']), '@source' => drupal_strtolower($source_profile_type['name']))),
Thank you very much :)
Comment | File | Size | Author |
---|---|---|---|
#1 | 1718958-1.profile_copy_placeholder.patch | 1.13 KB | rszrama |
#1 | placeholder-token-profile-copy.png | 10.27 KB | rszrama |
Comments
Comment #1
rszrama CreditAttribution: rszrama commentedWhat if we changed it to use the % placeholder instead?
Comment #2
krabbe CreditAttribution: krabbe commentedThank you, rszrama. The patch works perfect for me.
Comment #3
Anonymous (not verified) CreditAttribution: Anonymous commentedYepp, this patch works fine for me, thanks rszrama.
Comment #4
rszrama CreditAttribution: rszrama commentedAwesome, thanks. I'm not sure why test results aren't being returned; I'll sort that out and get it tested / committed.
Comment #5
rszrama CreditAttribution: rszrama commentedFixed the failing tests a couple days ago. Just committed this.