Can you add Windows support ?
Be careful, there is a bug with escapeshellarg for Windows see https://bugs.php.net/bug.php?id=49446

CommentFileSizeAuthor
#7 1717258-7.patch4.81 KBamateescu
#6 commerce_atos.patch4.1 KBMarcElbichon
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented

This was fixed in 5.3 with bug #43261

somebody is saying that in the link you pasted

MarcElbichon’s picture

MarcElbichon CreditAttribution: MarcElbichon commented

Yes but don't you want to be compatible with earlier version ?

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented

On windows, you receive request and response binaries with the .exe extension and what about other files ? What are the other differences ?

Yes but don't you want to be compatible with earlier version ?

what needs to be done to fix that ?

MarcElbichon’s picture

MarcElbichon CreditAttribution: MarcElbichon commented

There no other difference.
You may protect % sign by ^% for the command line but i'm not sure.

For bug with escapeshellarg, you can do this (awful) workaround :
To do only for Windows.

  • Replace all % by another string (ie : !$)
  • Get escapeshellarg() result
  • replace all previous string (!$) by %

See zip in #1714858 issue

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented

I'm not really able to work on that as I can't try on my environment, can you submit a patch for that ?

MarcElbichon’s picture

MarcElbichon CreditAttribution: MarcElbichon commented
FileSize
commerce_atos.patch4.1 KB

Here's a patch for Windows support. Must be applied to 01 sept dev version

amateescu’s picture

amateescu CreditAttribution: amateescu commented
FileSize
1717258-7.patch4.81 KB

Updated the patch to latest -dev version of this module (and cleaned-up some stuff in the process) :)

jsacksick’s picture

jsacksick CreditAttribution: jsacksick commented
Issue tags: +7.x-1.0 blocker

Mark this as a stable release blocker