Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Simply to fix.
Comment | File | Size | Author |
---|---|---|---|
#8 | theme_inc_tbody_DRUPAL-5-dev.patch | 1.48 KB | m1mic |
#5 | theme_inc_head_tbody_3.patch | 1.5 KB | dvessel |
#4 | theme_inc_head_tbody2.patch | 1.48 KB | m1mic |
#2 | theme_inc_head_tbody.patch | 1.48 KB | m1mic |
#1 | theme_inc_tbody.patch | 1.45 KB | m1mic |
Comments
Comment #1
m1mic CreditAttribution: m1mic commented@chx
Tested with:
Your patch worked to remove the empty tbody as advertised. However, if there are no rows in the table (in Calendar module's Prev/Next bar for example), validation still fails. This is because HTML requires that anything that has a thead tags must also have tbody tags. I updated your patch to include a ternary operator to check if there are rows, and if so, add the thead tags.
Comment #2
m1mic CreditAttribution: m1mic commentedLooks like the same issue is in Head. Updating the version number to 6.x-dev and adding a patch for Head.
Comment #3
Gábor Hojtsy- We don't use /* and */ multiline comments inside code.
- We do use spaces around ? in ternary operators.
Apart from this, this patch obviously only needs some testing, it looks good from here.
Comment #4
m1mic CreditAttribution: m1mic commentedThanks for the review Gábor! Converted mulitline comments into single line // comments. Added the proper spacing to the ternary operator.
Comment #5
dvessel CreditAttribution: dvessel commentedejhildreth, you have to diff from the root install. Here's a proper patch.
The closing /tbody was misplaced so that was corrected. Everything else is pretty much the same from your previous patch.
Tested and validates.
Comment #6
Gábor HojtsyThanks, committed.
Comment #7
(not verified) CreditAttribution: commentedComment #8
m1mic CreditAttribution: m1mic commentedBackporting: This bug is still in DRUPAL-5-dev
Comment #9
m1mic CreditAttribution: m1mic commentedComment #10
drummCommitted to 5.x.
Comment #11
Anonymous (not verified) CreditAttribution: Anonymous commentedAutomatically closed -- issue fixed for two weeks with no activity.