Don't include core modules in make file. [#1714332]

Comment	File	Size	Author
	profiler_builder-makefile-dont-include-core-modules.patch	496 bytes	Robin Millette

Comment #1

btopro CreditAttribution: btopro commented 5 August 2012 at 19:06

is there a need for literal evaluation or could it be as your issue above suggests. Might also be nice to have a way of defining the groupings of modules to ignore if you know you are creating things that are custom always thrown in 'Custom' for example and then want them removed from any export.

Also as there is no if - continue; style statements in the rest of the code doing the normal evaluation wrapper might be good for consistency {}

Log in or register to post comments

Comment #2

Robin Millette CreditAttribution: Robin Millette commented 6 August 2012 at 14:13

Well, there's the ever present confusion between module and project, true. I'd vote to open another issue. This was a quick fix to address the noise created by core modules: no need for make to download those, ever.

Would you consider a co-maintainer if I promise to always wrap my "if"s in {}?

Log in or register to post comments

Comment #3

btopro CreditAttribution: btopro commented 6 August 2012 at 15:10

lol, yes, as you've made more contributions to this in the last few days then I have in a year I'll add you in.

Log in or register to post comments

Comment #4

Robin Millette CreditAttribution: Robin Millette commented 6 August 2012 at 17:34

Thanks! I'm now a co-maintainer, woot :-)

Can I commit this if I change it to

if ('Core' === $package) {
  continue;
}

I prefer that code to

if ('Core' !== $package) {
  // rest of the code
}

since that has a tendency of pushing code into further and further indentation.

I will also open another issue for the larger case, confusing modules and projects if we agree on this plan.

Log in or register to post comments

Comment #5

btopro CreditAttribution: btopro commented 6 August 2012 at 17:50

I don't personally nest stuff with continue but your a comaintainer so just make sure it's documented ;) as to ignoring that Core group. I'd still rather see a hook that allows for groupings to be pruned (and altered) while having profiler_builder have the default pruning of things belonging to core. A module list of things to prune is still better for machine convention though I see why this would be more efficient, especially for Core things (though Core modules aren't going to change within a branch...)