See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).

CommentFileSizeAuthor
#7 forum-tests-1711348-7.patch2.9 KBlarowlan
#7 1711348-interdiff2.txt659 byteslarowlan
#5 forum-1711348-5.patch2.9 KBkid_icarus
#5 interdiff.txt1.66 KBkid_icarus
#1 drupal-1711348-1.patch2.73 KBkid_icarus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Assigned: Unassigned » kid_icarus
Status: Active » Needs review
FileSize
drupal-1711348-1.patch2.73 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

3/3

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Needs work

Needs doxygen fix as discussed in IRC. :)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

See the summary of #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules) for how the docblock should be added.

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.66 KB
forum-1711348-5.patch2.9 KB
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented 
+++ b/core/modules/forum/lib/Drupal/forum/Tests/ForumTest.phpundefined
@@ -64,7 +71,7 @@ class ForumTest extends WebTestBase {
+    parent::setUp();
     // Create users.

Minor point, but should we add a blank line above the inline comment here?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
FileSize
1711348-interdiff2.txt659 bytes
forum-tests-1711348-7.patch2.9 KB

Added blank line as requested by xjm

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Reviewed & tested by the community

Alright, this looks fine. :)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Closed (duplicate)