See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).

CommentFileSizeAuthor
#8 block-1711286-8.patch9.39 KBxjm
#8 interdiff.txt6.21 KBxjm
#3 drupal-1711286-3.patch8.76 KBkid_icarus
#3 interdiff.txt1.38 KBkid_icarus
#1 drupal-1711286-1.patch7.06 KBkid_icarus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Assigned: Unassigned » kid_icarus
Status: Active » Needs review
FileSize
drupal-1711286-1.patch7.06 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Needs work

What about NewDefaultThemeBlocksTest.php and NonDefaultBlockAdminTest.php ?

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
FileSize
interdiff.txt1.38 KB
drupal-1711286-3.patch8.76 KB

Whoops!

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Status: Needs work » Needs review
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Great, that's all of them. Making sure I'm paying attention, huh? ;)

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented

Lol :)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Needs work

Needs doxygen fix as discussed in IRC. :)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs work » Needs review
FileSize
interdiff.txt6.21 KB
block-1711286-8.patch9.39 KB
droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs review » Reviewed & tested by the community
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Closed (duplicate)