Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The phone module page lists two maintainers, one last commited 21weeks ago with a total of 2, the other one more than a year ago. I also see that many patches are circling in review.
Without being related to this project or interested in doing it:
- does this project need new maintainers?
- if yes, somebody willing to do it?
Comments
Comment #1
rfsbsbThese are good questions. If there's need to help out as a co-maintainer I would candidate myself.
Comment #2
g1smd CreditAttribution: g1smd commentedI am rewriting many of the country specific modules at the moment.
I don't want to take on any long term commitment with this module.
Comment #3
ChristianAdamski CreditAttribution: ChristianAdamski commentedSo, what do we do? Contact current maintainers?
The phone module doesn't seem to be hugely active in general.
Comment #4
rfsbsbI've already sent an e-mail to cweagans but no answer up to this moment.
Comment #5
rfsbsbJust to let you know, cweagans answered me and said he will review my patches and, if everything is okay, he will add me as co-maintainer!
Comment #6
jonathan_hunt CreditAttribution: jonathan_hunt commentedThanks for putting your hand up @rfsbsb. Any news on this? It would be good to get a 7.x release available, perhaps a beta?
Comment #7
rfsbsbHi @jonathan_hunt no answer so far.
Comment #8
g1smd CreditAttribution: g1smd commentedWhile you're waiting for news, anyone care to test the 5 country modules I have already rewritten?
I've stopped editing others until there is more news on what the future holds.
Comment #9
Alconaft43 CreditAttribution: Alconaft43 commentedValidation of international numbers must be rewritten if we take to the account that number which can be dialed from the real phone is correct a prior. I can not get validated norwegian numbers like +4746000000 (I must add space after country code to pass validation) or 004746000000. I think possibility to use 00 instead + which is common for most of the countries is not implemented at all.
Comment #10
Alconaft43 CreditAttribution: Alconaft43 commentedSomething is really wrong with international phone number validator phone.int.inc, check first line of the file:
function phone_int_metadata() {
// These strings are translated using t() on output.
return array(
'error' => '"%value" is not a valid Italian phone number
Italian phone numbers should only ...',
);
}
What "Italian" doing there, wrong copy-paste ? :)
Comment #11
g1smd CreditAttribution: g1smd commentedI have a huge list of issues that I have fixed or was in the process of fixing or have noted to fix soon, but without the project owner being present or anyone else that can actually commit these changes its going to be a while before they all see the light of day.
Comment #12
ChristianAdamski CreditAttribution: ChristianAdamski commentedSo, what do we do? Is there a third party within the Drupal commmunity that can be involved to revive this project?
Comment #13
cweagansHey guys, sorry for the radio silence - I've been incredibly busy. I've cleared out the RTBC queue for the phone module tonight, which should help to resolve some long-standing issues.
@rfsbsb: I've given you commit access to the repository. Please feel free to commit to the 6.x-1.x and 7.x-1.x branches as you see fit. Please ensure that you give each patch proper review and don't just commit things if they aren't ready. Please note that we're going to be rewriting phone module in the 7.x-2.x branch. I'd ask that you do not commit there unless we talk about it first - for the first few months, please limit yourself to 6.x-1.x and 7.x-1.x.
Thanks for your patience everyone.
Comment #14
rfsbsbHi @cweagans thank you very much!
I'll try to do a good job as co-maintainer and help as much as I can! I'll not touch branch 7.x-2.x, don't worry ;-)
Thank you again.