Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
#1380958: Replace $modules list for WebTestBase::setUp() with ::$modules class properties changed how a test can specify which modules to enable.
Comment | File | Size | Author |
---|---|---|---|
#9 | node-1710300-9.patch | 18.09 KB | tim.plunkett |
#4 | drupal-1710300-4.patch | 17.02 KB | tim.plunkett |
#4 | interdiff.txt | 2.39 KB | tim.plunkett |
#1 | drupal-1710300-1.patch | 16.76 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettSee attached.
Comment #2
tstoecklerThe comment should also be removed.
Otherwise looks very good.
Comment #3
ksenzeeI wonder if the comments should be moved to above the static property, instead of deleting them entirely. It might be useful in some cases to explain what the test modules are meant to do.
Comment #4
tim.plunkettSure.
Comment #5
tim.plunkettKeeping title in line.
Comment #6
tstoecklerComment #7
xjmNeeds doxygen fix as discussed in IRC. :)
Comment #8
xjmSee the summary of #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules) for how the docblock should be added. Also, note that the current docblock for NodeAccessRecordsTest should be switched so that it has a one-line summary (same as classes and methods do, though it doesn't need to start with a verb.) In this case we might get away with saying "Enable a module that implements node access API hooks and alter hooks". (Edit: I'm on the fence as to whether that should have the infamous s.) ;)
Edit: The fact that
node_test
implements the node access API is... interesting, to say the least, based on how it's used. But that's out of scope for this issue.Comment #9
tim.plunkettRerolled for docblock fixes.
Comment #10
xjmStray quote. :) Also, "alter hooks" should probably be plural.
We can probably remove the first lin here and use the second as the summary?
Comment #11
tim.plunkettI agree, I'm making this change directly in the massive patch for #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules)