Clean up mime type detection and tarball management [#1706738]

drush_mime_content_type() is a function living in commands/make/make.download.inc.

drush_tarball_extract() duplicates effort and try to guess the content type for files by similar means.

make_download_file_unpack() overlaps with drush_tarball_extract() to some extent.

The task is to consolidate drush_mime_content_type() in includes/drush.inc and decouple tarball management.

Comments

Comment #1

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan commented 31 July 2012 at 22:43

Title:

Extend and leverage drush_mime_content_type()

» Clean up mime type detection and tarball management

Comment #2

jonhattan

Spanish

Plasencia

CreditAttribution: jonhattan commented 1 August 2012 at 17:52

Status:

Active

» Fixed

Commit f59b229

Changes done:

* consolidate drush_mime_content_type(): 1. try php's builtin ; 2. try magic headers (add support for bz2) ; 3. try filename extensions (only for .tar at present)
* remove any mime detection code from drush_tarball_extract()
* new function drush_file_is_tarball() to check if a file has a format valid for drush extraction.
* error handling in drush_tarball_extract()
* fix a dirty hack in drush_lib_fetch()