'Run import' instructions may point to a non-existent page if fontyourface_ui.module is not enabled [#1705158]

When running my disable/uninstall tests without cleaning up properly after previous experiments, I managed to end up with the following ~~situation~~mess:

@font-your-face main module is enabled,
Google Fonts API module is enabled but fonts are not imported yet,
@font-your-face UI module is not enabled,
some Google fonts are declared in themename.info.

I get

The google_fonts_api font that is added to the theme .info file cannot be loaded. This is probably because the import has not been run yet. Run import to add fonts.

...but the link points to a page that isn't there. (its menu parent, admin/config/user-interface, is loaded instead)

This might well be an edge case, but the ability of users to get into edge cases should not be underestimated. :) Probably the message should read 'Enable @font-your-face UI module and run import to add fonts' if UI module is not enabled.

Comment	File	Size	Author
#2	fontyourface-Fix_Run_import_instructions_if_fontyourface_UI_not_enabled_1705158-2.patch	1.76 KB	Drave Robber
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

sreynen CreditAttribution: sreynen commented 30 July 2012 at 12:32

I agree, we should change the message to suggest enabling the UI (without a link to a UI page) if it's not already enabled. This made me think it could also be nice to have a way to do imports without the UI: #1705216: Add Drush integration

Comment #2

Drave Robber CreditAttribution: Drave Robber commented 30 July 2012 at 20:10

Status:

Active

» Needs review

File	Size
fontyourface-Fix_Run_import_instructions_if_fontyourface_UI_not_enabled_1705158-2.patch	1.76 KB

This is indeed an edge case, because in addition to all the mess listed in #0 it also takes missing internet connection at the moment Google Fonts API module is enabled (if there is connection, import runs automatically).

Here's a patch nevertheless.