Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
Thanks for the module!.
Since the nodes of this content type have no title, in the admin> content - all titles are missing.
Title should be given as an option, since it is always a good way for he admin to...well... give it a title ;)
Title should not be shown to the user.
What do you think?
Comment | File | Size | Author |
---|---|---|---|
#7 | admin_message_titles.patch | 1.1 KB | anders.fajerson |
#3 | admin_message_titles.patch | 630 bytes | Christefano-oldaccount |
Comments
Comment #1
anders.fajerson CreditAttribution: anders.fajerson commentedYes, I have definately been giving it some thought. It might not have been the best idea to disable the title. The reason you give is probably the most obvious one.
I'll look into it if I can enable it again and provide an uppgrade path.
Comment #2
amanire CreditAttribution: amanire commented+1 It would be nice to be able to use this module in combination w/the Automatic Nodetitles module.
Comment #3
Christefano-oldaccount CreditAttribution: Christefano-oldaccount commentedAnother good reason for titles is so that the search module can display a title for admin messages in search results. This is something I need on a site I'm working on and when I took a look I realized that Admin message doesn't use hook_node_info().
Here's a patch that adds that. I haven't applied it on a running site to see what happens (I didn't have many admin messages so an upgrade path wasn't a big deal for me -- I just disabled Admin message, added a function, deleted the Admin message content type and re-enabled the module). Be sure to backup your messages (and related custom PHP rules) first.
Comment #4
Christefano-oldaccount CreditAttribution: Christefano-oldaccount commentedComment #5
anders.fajerson CreditAttribution: anders.fajerson commentedThanks for the patch! Are you sure hook_node_info() is needed here? I was thinking of enabling the title in an update function.
Comment #6
Christefano-oldaccount CreditAttribution: Christefano-oldaccount commentedModules that create their own content type (like bio and usernode) are using hook_node_info() and I'm pretty sure it's needed here.
Can you say more about what you were thinking about an update function? That sounds important for a proper upgrade path.
Comment #7
anders.fajerson CreditAttribution: anders.fajerson commentedThis should do the trick. I'm not using node_info() to implement this modules content type, instead I'm using node_type_save().
Comment #8
Christefano-oldaccount CreditAttribution: Christefano-oldaccount commentedI reversed the effects of my patch and gave #7 a try and it works as it should. I think this is RTBC but won't change status since I didn't have any admin_message nodes to migrate.
Amitaibu or amanire, can you review this?
Comment #9
anders.fajerson CreditAttribution: anders.fajerson commentedI've committed a slightly altered version of this patch: http://drupal.org/cvs?commit=91152
Comment #10
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.