Hi,
Thanks for the module!.
Since the nodes of this content type have no title, in the admin> content - all titles are missing.

Title should be given as an option, since it is always a good way for he admin to...well... give it a title ;)

Title should not be shown to the user.

What do you think?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

anders.fajerson’s picture

Yes, I have definately been giving it some thought. It might not have been the best idea to disable the title. The reason you give is probably the most obvious one.

I'll look into it if I can enable it again and provide an uppgrade path.

amanire’s picture

+1 It would be nice to be able to use this module in combination w/the Automatic Nodetitles module.

Christefano-oldaccount’s picture

FileSize
630 bytes

Another good reason for titles is so that the search module can display a title for admin messages in search results. This is something I need on a site I'm working on and when I took a look I realized that Admin message doesn't use hook_node_info().

Here's a patch that adds that. I haven't applied it on a running site to see what happens (I didn't have many admin messages so an upgrade path wasn't a big deal for me -- I just disabled Admin message, added a function, deleted the Admin message content type and re-enabled the module). Be sure to backup your messages (and related custom PHP rules) first.

Christefano-oldaccount’s picture

Status: Active » Needs review
anders.fajerson’s picture

Thanks for the patch! Are you sure hook_node_info() is needed here? I was thinking of enabling the title in an update function.

Christefano-oldaccount’s picture

Modules that create their own content type (like bio and usernode) are using hook_node_info() and I'm pretty sure it's needed here.

Can you say more about what you were thinking about an update function? That sounds important for a proper upgrade path.

anders.fajerson’s picture

This should do the trick. I'm not using node_info() to implement this modules content type, instead I'm using node_type_save().

Christefano-oldaccount’s picture

I reversed the effects of my patch and gave #7 a try and it works as it should. I think this is RTBC but won't change status since I didn't have any admin_message nodes to migrate.

Amitaibu or amanire, can you review this?

anders.fajerson’s picture

Status: Needs review » Fixed

I've committed a slightly altered version of this patch: http://drupal.org/cvs?commit=91152

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.