Wizard and $_GET['destination'] [#1702498]

The multistep wizard and $_GET['destination'] doesn't play well together. As I could really use the ability to get the wizard form to redirect users back when they press save (but not when they press update), here's a patch that I believe improves the situation.

It makes sure that the destination parameter persists when passing from wizard page to wizard page, and redirects back to the url of the destination paramerter when returning or canceling.

Relies on the fix in #1702492: Drupal 6 code in wizard.

Comment	File	Size	Author
#8	ctools-destination-in-wizard-1702498-8.patch	824 bytes	bonrita
#7	ctools-destination-in-wizard-1702498-7.patch	812 bytes	bonrita
#3	ctools-destination-in-wizard-1702498-3.patch	1.8 KB	arnested
#2	ctools-destination-in-wizard-1702498-2.patch	2.44 KB	xen
	ctools-destination-in-wizard.patch	2.43 KB	xen

Comments

Comment #1

xen commented 27 July 2012 at 11:52

The panels patch in #1702506: Admin links for mini panel content type shows this one in action.

Comment #2

xen commented 2 August 2012 at 14:29

Status	File	Size
new	ctools-destination-in-wizard-1702498-2.patch	2.44 KB

Found a notice, here's a new patch. Took the oppotunity to use !empty everywhere.

Comment #3

arnested commented 13 August 2012 at 13:20

Status	File	Size
new	ctools-destination-in-wizard-1702498-3.patch	1.8 KB

Hmm... some debugging and code review revealed a few issues:

- "static $destination" is not needed in ctools_wizard_get_path()

- mini panel is not saved. Removing the addition to ctools_wizard_defaults() fixes this although I currently can't explain why (probably because destination is set as query parameter in $form_state['redirect'].