Rather than selecting a file via pre-built JSON and including all the possible files via drupal_add_js(), we should rather update the media thumbnail via AJAX request like file/%file/ajax/preview.

CommentFileSizeAuthor
#6 media-update_thumbnail_ajax-1701914-6-7.x-2.0-beta1.patch555 bytesgrom358
#4 interdiff.txt760 byteskim.pepper
#3 media-update_thumbnail_ajax-1701914-3.patch555 bytesmstrelan
#2 media.code_.1701914-2.patch527 byteslarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Maybe as a next step beyond this, we should probably be updating the entire widget for that delta once a file is selected. Say for instance that the user changes a field value on the file, which is used to determine entity access.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Active » Needs review
FileSize
media.code_.1701914-2.patch527 bytes

This works for me

mstrelan’s picture

mstrelan CreditAttribution: mstrelan commented
Issue summary: View changes
FileSize
media-update_thumbnail_ajax-1701914-3.patch555 bytes

I'm getting "Strict warning: Only variables should be passed by reference in media_file_edit_modal()" with this patch. Updated patch attached.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
CreditAttribution: kim.pepper at PreviousNext commented
FileSize
interdiff.txt760 bytes

Attaching interdiff between #2 and #3

m1r1k’s picture

m1r1k CreditAttribution: m1r1k at Propeople (now part of FFW) for Propeople (now part of FFW) commented
Status: Needs review » Reviewed & tested by the community

Works great for me

grom358’s picture

grom358 CreditAttribution: grom358 commented
FileSize
media-update_thumbnail_ajax-1701914-6-7.x-2.0-beta1.patch555 bytes

Patch for 7.x-2.0-beta1 release.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented

  • Dave Reid committed fc1c812 on 7.x-2.x authored by grom358 
    Issue #1701914 by larowlan, mstrelan, grom358, kim.pepper, Dave Reid:...
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid as a volunteer and at Lullabot commented
Title: Update the media thumbnail via AJAX when media browser or edit file modal is closed » Update the media thumbnail via AJAX when edit file modal is closed
Status: Reviewed & tested by the community » Fixed

Committed #3 to 7.x-2.x. Nice work everyone, that ended up being way easier than expected!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.