Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When creating a new translation, the default language (which is a disabled field) is being set to the original language of the node.
Also when editing an existing translation of a node, the language of the translation is being omitted from the language list.
I will upload a patch for this shortly.
Comment | File | Size | Author |
---|---|---|---|
#12 | dropdown-stop-gab-1701460.patch | 689 bytes | bforchhammer |
#8 | default-language-fix-1701460-8.patch | 1.38 KB | bforchhammer |
#3 | entity_translation-language_field-1701460-3.patch | 2.03 KB | khaled.zaidan |
#1 | entity_translation-language_field-1701460-1.patch | 2.03 KB | khaled.zaidan |
Comments
Comment #1
khaled.zaidan CreditAttribution: khaled.zaidan commentedHere is a patch to fix the issue.
I did some testing on a clean installation and it seems to work correctly.
But I would still love if someone else could give it a quick look.
Comment #3
khaled.zaidan CreditAttribution: khaled.zaidan commentedOK last patch failed to be applied. Here's another try.
Comment #4
khaled.zaidan CreditAttribution: khaled.zaidan commentedChanging status to 'needs review'.
Comment #5
issa.haddadin CreditAttribution: issa.haddadin commentedThank you! it worked with me and all good.
Comment #6
khaled.zaidan CreditAttribution: khaled.zaidan commentedIssue shouldn't be marked as closed/fixed yet :)
Wait until the fix is committed, otherwise nobody will ever see this ;)
Comment #7
plachThis is not something I'm inclined to do, because not every entity has a language property. Why is this needed here?
This is changing the original entity language, many things would be screwed by this I think.
Instead I think we need a copy of the language widget, something like:
Comment #8
bforchhammer CreditAttribution: bforchhammer commentedHere's a patch based on the plach's suggestion in #8.
Comment #9
plachIf we want to support also changing the translation language we need an active language selector. However it's not clear from the UX folks which direction is the desired one.
Comment #10
bforchhammer CreditAttribution: bforchhammer commentedRight, patch above only fixes the issue with the disabled language dropdown being confusing...
@plach do you think we can postpone the feature for changing the translation language, and go ahead with fixing the current issue? I'd also be happy with removing the dropdown completely, but I remember reading somewhere that it has to stay (I don't remember why).
Comment #11
plachI think there is a value in having the entity language always shown for information, but it should be labelled as such. If we want to change the translation language the selector has to be active. The patch in #8 does not improve UX in any of the two directions IMHO.
EDIT: As a stop gap I'd just rename the "Language" label to something like "Original language".
Comment #12
bforchhammer CreditAttribution: bforchhammer commentedOkay, so shall we just adjust the title for now?
Comment #13
plachYep, let's leave this open after commit for future improvements if we decide to make the translation language changeable.
Comment #14
bforchhammer CreditAttribution: bforchhammer commentedCommitted #12. Back to Active.
Comment #15
plachComment #16
plachActually this is postponed to the discussion in #1282018: Improve UX of language-aware entity forms.