'View Slideshow' feature doesn't work [#16928]

When trying to view slideshow of an album, '//' appears at the top of the drupal page and the slideshow never starts. When you click on 'pause' and then click on 'resume', the gallery module is exited and you are returned to the home page. I tried this on the walkah drupal+gallery integration test site http://aurora.walkah.net/drupalgallery/ and got the same results.

Comment	File	Size	Author
#2	g2_js_fix.patch	887 bytes	TDobes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

(not verified) CreditAttribution: commented 7 February 2005 at 14:16

The '//' appearing at the top of drupal was seen using Firefox.

The output at the top of drupal using IE is as follows:

//= 4) && (agent.indexOf('msie 4') == -1) && (agent.indexOf('msie 5.0') == -1); var filterNames = new Array(16), filters = new Array(16); filterNames[0] = 'Blend'; filters[0] = 'progid:DXImageTransform.Microsoft.Fade(duration=1)'; filterNames[1] = 'Blinds'; filters[1] = 'progid:DXImageTransform.Microsoft.Blinds(duration=1,bands=20)'; filterNames[2] = 'Checkerboard'; filters[2] = 'progid:DXImageTransform.Microsoft.Checkerboard(duration=1,squaresX=20,squaresY=20)'; filterNames[3] = 'Diagonal'; filters[3] = 'progid:DXImageTransform.Microsoft.Strips(duration=1,motion=rightdown)'; filterNames[4] = 'Doors'; filters[4] = 'progid:DXImageTransform.Microsoft.Barn(duration=1,orientation=vertical)'; filterNames[5] = 'Gradient'; filters[5] = 'progid:DXImageTransform.Microsoft.GradientWipe(duration=1)'; filterNames[6] = 'Iris'; filters[6] = 'progid:DXImageTransform.Microsoft.Iris(duration=1,motion=out)'; filterNames[7] = 'Pinwheel'; filters[7] = 'progid:DXImageTransform.Microsoft.Wheel(duration=1,spokes=12)'; filterNames[8] = 'Pixelate'; filters[8] = 'progid:DXImageTransform.Microsoft.Pixelate(duration=1,maxSquare=10)'; filterNames[9] = 'Radial'; filters[9] = 'progid:DXImageTransform.Microsoft.RadialWipe(duration=1,wipeStyle=clock)'; filterNames[10] = 'Rain';

filters[10] = 'progid:DXImageTransform.Microsoft.RandomBars(duration=1,orientation=vertical)'; filterNames[11] = 'Slide'; filters[11] = 'progid:DXImageTransform.Microsoft.Slide(duration=1,slideStyle=push)'; filterNames[12] = 'Snow'; filters[12] = 'progid:DXImageTransform.Microsoft.RandomDissolve(duration=1,orientation=vertical)'; filterNames[13] = 'Spiral'; filters[13] = 'progid:DXImageTransform.Microsoft.Spiral(duration=1,gridSizeX=40,gridSizeY=40)'; filterNames[14] = 'Stretch'; filters[14] = 'progid:DXImageTransform.Microsoft.Stretch(duration=1,stretchStyle=push)'; filterNames[15] = 'RANDOM'; filters[15] = 'RANDOM'; // ]]>

Comment #2

TDobes CreditAttribution: TDobes commented 16 February 2005 at 23:49

File	Size
g2_js_fix.patch	887 bytes

The attached patch fixes the problem, though I do not know enough about the g2 architecture to know whether the problem should be fixed in the Drupal module (as I did) or in G2 somehow.

The javascript was not being surrounded by the appropriate script tags... I made the gallery module add them for pages where javascript exists.

Note that there is another problem with slideshows: Slideshow pages seem to be lacking a breadcrumb.