subs roles - assign automatically role for a subs based on status

here the patch

hi,

First of all, thanks for review and feedback !

I don't really like how we can only pick one status ...

That's true. This is only for simple use case...Otherwise, i fear that it begins to be more complex...

... and how its risky to get roles accidentally removed.

I agree but thinking this is more in charge to the administrator to deals and take care about this. For e.g :

- a user have already a role 'foo' for particular reason. He subscribe to a role which set the role 'foo' again. When subs will be expired, this role will be removed even if he have this role before being subscribe.
- a user have a role 'foo' assign by subs '1'. He is also subscribe to subs '2' which set the same role 'foo'. If only one of this subs have been expired (in fact match the subs status triggered), for e.g subs 1 expired, role 'foo' will be removed even if he is still subscribe to subs '2'.
- sure i have miss some other use cases ? Did you have any other ideas ?

So, we could conclude that limits are :
- create specific roles which are only deals with subs status
- set further roles to only one subs type which are trigger by only one subs status

Indeed, if you have a lot of subcriptions types and roles to assign, it begins to be a real mess...!

Could we maybe create a new set and unset roles rule per subs type instead? If not, we should allow the user to specify N conditions; for each status we should be able to add/remove any number of roles.

Did you means creating automatically rules (for administrator which don't know and don't have to administer rules) ?
I confess that i'm not a rules expert...! And it could be a real pain to implement it (mostly if administators could manage to use rules directly...)

Personally I think the rules approach is cleaner but I'm not sure if it fits your use case.

Of course ! If an administrator could create a rule each time there is a new role to assign to a particular status (and mostly if further conditions need to be matched), this is definitively better and this module don't have to be used ! But in our simple use case, administrator just cannot manage with rules module...

To resume, this simple module aims at :
- adding/removing further specific roles to only one subs type which are trigger by only one subs status. It means that :
-> this roles are specific to only one subs types
-> this roles needs to be added/removed only through subs status
-> it concerns only simple use case (otherwise, use rules module or custom code)
- to be an helper module for administrator which don't know how to use rules and mostly don't have permission to use it !
- provide a way for similar simple use case to project which don't need to use rules module...

These points underlines that it still needs some work :
- on the subs type edit page, check that a role isn't already used by an another subs type

Finally, i think we could say that :
- this module haven't to be added to subs project. If needs are more complex, just used an another way to do it (rules, custom code). So subs could clearly live without this module !
- open a new project instead ?

Are you agree with this or i miss something ?

Thank you again for feedback

Anyway where to go from here, here an another patch which :

- fix issue above :

on the subs type edit page, check that a role isn't already used by an another subs type

- a simple views integration (field handlers for roles to add/remove per subs types)

As see with alexweber, live into its own project now.

Currently available in sandbox but would be soon promote to full project.