Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options: 

/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global Drupal, jQuery */

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.

Files: tableheader.js

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented 
core/misc/tableheader.js: line 86, col 62, eval is evil.

See #1574738: Rewrite tableheader.js for a fix.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Active » Postponed

Needs the rewrite to be fixed.

seutje’s picture

seutje CreditAttribution: seutje commented

Isn't it kinda silly to ignore JShint while rewriting? I would think it makes more sense to do JShint stuff before doing a full rewrite. Or maybe do it both at the same time.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented

we're not ignoring it, after the rewrite we'll close this one as "works as designed". Just keeping the overall state of the issues coherent for new people.

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Status: Postponed » Closed (works as designed)

All clean :)