Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Run jshint on the files with the configuration from the parent issue or use with the following options:

/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global Drupal, jQuery */

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.

Files: progress.js

#4 core-jshint-progress.js-1684806-4.patch402 bytesnod_
PASSED: [[SimpleTest]]: [MySQL] 55,892 pass(es).
[ View ]


nod_’s picture

Missing a capital for progressBar since it is a constructor. JSHint doesn't catch it but it needs to be fixed.

nod_’s picture

Status:Active» Closed (works as designed)

Touches several files and is not a JSHint error since Drupal does have a capital letter even if it's not really the constructor.
See: #1684906: Drupal.progressBar is a constructor, rename it Drupal.ProgressBar

nod_’s picture

Status:Closed (works as designed)» Needs work

New JSHint config #1995996: Update JSHint configuration.

core/misc/progress.js: line 16, col 9, 'pb' is defined but never used.
nod_’s picture

Status:Needs work» Needs review
new402 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,892 pass(es).
[ View ]
droplet’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed cc71d8d and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.