event_get_offset() in event module, not date module; not included [#168081]

A call to the function event_get_offset() in calendar.module is preceeded by include_once(DATE_TIMEZONES); which includes a file packaged with the date module, but in fact the function in question is provided by a similar file packaged with the event module. The file to be included should be EVENT_PATH.'/event_timezones.inc. As a consequence, calendar ought to declare a dependency on the event module. (There does seem to be some overlap between these two files, though. Perhaps it would be better to merge them and provide all these functions in the date API package.)

Trivial patch attached.

Comment	File	Size	Author
	calendar.module_event_timezone_bug.diff	1.58 KB	mvc

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

KarenS CreditAttribution: KarenS commented 2 September 2007 at 19:34

Status:

Needs review

» Fixed

There is copy of that included with the date module that is used when the event module is not enabled, so there is no dependency on the Event module. There are two problems that cause this error message and I am working on them:

1) The 5.2 version of the Event module no longer has that file, so the code that assumed it was there is now wrong, but only for that version of the Event module, not for earlier versions.

2) Sometimes code is not getting loaded in the right order and functions are getting called before the file that has the function has been loaded. I have tried a number of fixes to try to get that working right, but it is still sometimes a problem.

At any rate, the problem is not a dependency on the Event module, and there are other issues reporting this problem already, so I'm closing this one.