for drupal installation in directory block_search redirect wrong. [#1668454]

In our site the block_search is redirecting bad cause the path is incomplete cleaned. For example:

We got example.com/mydrupal as base path drupal installation, then our "core search" is "search/apachesolr_search" the result for a normal search will be:

exmaple.com/mydrupal/search/apachesolr_search/

But it's not our case. The redirect it's doing a wrong path,

exmaple.com/mydrupal/mydrupal/search/apachesolr_search/.

This happen because for our site the "base_path" it's not "/" is "/mydrupal/".

I figure out that some fix can be recodding this line.

($path{0} == "/" ) ? $path = substr($path, 1) : '';

Comment	File	Size	Author
#7	1668454-7.patch	1003 bytes	Nick_vh
#7
#1	1668454-1.patch	676 bytes	killua99
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

killua99 CreditAttribution: killua99 commented 2 July 2012 at 15:45

Status:

Active

» Needs review

File	Size
1668454-1.patch	676 bytes

This is a fix for my case, but need review to see if it correct.

Comment #2

Nick_vh

he/him

Ghent

CreditAttribution: Nick_vh commented 18 September 2012 at 13:56

Status:

Needs review

» Needs work

Could you write down a small tutorial how we can replicate this? I'd like to add some simpletests for this case as it is a sensitive thing

Comment #3

pwolanin CreditAttribution: pwolanin commented 19 September 2012 at 20:16

I don't think you can have a test install in a subdir?

Also, our function looks rather different from: http://api.drupal.org/api/drupal/modules%21search%21search.module/functi...

maybe worth digging into what's going on in more depth?

Comment #4

pwolanin CreditAttribution: pwolanin commented 20 September 2012 at 18:15

Status:

Needs work

» Active

committing the patch in #1 above since this is an annoying bug, but I think we need to revisit for a more robust solution.

Comment #5

killua99 CreditAttribution: killua99 commented 3 October 2012 at 10:00

And this commit is under my name? ^_^ just to know.

Actually I'll try to dig in and see if this is right? solution.

Comment #6

Nick_vh

he/him

Ghent

CreditAttribution: Nick_vh commented 16 October 2012 at 08:33

Status:

Active

» Postponed

postponed until we decide to revisit this or until someone wants to take a crack to this problem

Comment #7

Nick_vh

he/him

Ghent

CreditAttribution: Nick_vh commented 22 May 2013 at 20:56

File	Size
1668454-7.patch	1003 bytes

Revisited this a little bit and added some more commenting to make it clear what it does exactly. Committing and closing this issue. I think the approach you chose was quite ok. I could rewrite it to be less cryptic but I don't see why.