This isn't a true field, but a computed one, so should be flagged as such.

Files: 
CommentFileSizeAuthor
#4 16625380-4.patch3.78 KBamateescu
PASSED: [[SimpleTest]]: [MySQL] 3,589 pass(es). View
#1 1662538.commerce.creator-property-computed.patch651 bytesjoachim
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1662538.commerce.creator-property-computed.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

joachim’s picture

Status: Active » Needs review
FileSize
651 bytes
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1662538.commerce.creator-property-computed.patch. Unable to apply patch. See the log in the details link for more information. View

Here's a patch.

Status: Needs review » Needs work

The last submitted patch, 1662538.commerce.creator-property-computed.patch, failed testing.

rszrama’s picture

Title: 'creator' should be set as 'computed' in commerce_product_entity_property_info » Properly indicate "computed" properties in our hook_entity_property_info() implementations
Component: Product » Developer experience
Status: Needs work » Active

Let's generalize this, as we surely have other computed properties that aren't designated. A quick grep of the source showed we are only using this for the mail_username property of the Order entity, so it's possible this parameter was a late addition to the Entity API. : ?

amateescu’s picture

Status: Active » Needs review
FileSize
3.78 KB
PASSED: [[SimpleTest]]: [MySQL] 3,589 pass(es). View

This should do it.

rszrama’s picture

Status: Needs review » Fixed

You da man. Committed!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.