Following #22336: Move all core Drupal files under a /core folder to improve usability and upgrades, we should move Drupal Core's install profiles to core/profiles to live alongside core/modules and core/themes. Once we have core/profiles, we will then be able to extend the discovery of profiles to sites/all/profiles in a follow up issue.

Follow ups

CommentFileSizeAuthor
#2 1661468.patch12.78 KBRobLoach
profiles.patch10.84 KBRobLoach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, profiles.patch, failed testing.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs work » Needs review
FileSize
1661468.patch12.78 KB
glennpratt’s picture

glennpratt CreditAttribution: glennpratt commented

Patch looks good, though I haven't tested it. +1 for consistency.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community

Various file paths cannot just be replaced with the core/ directory prefix. As a consequence, that would require to put custom profiles into core/profiles/ as well.

But alas, the intention of this issue is to move the core profiles into core/profiles first, without caring for custom profiles. Re-instantiating /profiles for custom profiles is left for #562042: Search for install profiles in sites/[all|site]/profiles folders, and move core profiles into /core/profiles

I'm not sure I agree with this split and whether it's a good idea, but if we do it this way, then aforementioned issue has to be bumped to a critical task and release blocker. I guess I'd rather prefer to do both in one to prevent that critical release blocker scenario.

Leaving for core committers to decide, so tentatively marking RTBC, as this patch looks ok to me, if we want to take the split-route.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work

Hm. I think since this would change a "nice to have" thing into a "critical release blocker" task, I'd prefer to handle them in the same patch, if that's ok.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs work » Closed (duplicate)

Yeah; as mentioned I wasn't really fond of that strategy either. So let's move this patch over to the originating issue and perform the full change there.