Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
OK, let's try one of the big ones. This patch slides system.module nearly clean in half. That's a savings of about 1600 lines. I also added a few more comments to functions, but otherwise no functional changes.
Let's see if this can get in before some other patch breaks it horribly. :-)
Comment | File | Size | Author |
---|---|---|---|
#20 | system_28.patch | 160.61 KB | pwolanin |
#16 | system_27.patch | 161.03 KB | Crell |
#14 | system_26.patch | 161.02 KB | Crell |
#8 | system_25.patch | 161.34 KB | Crell |
#4 | system_24.patch | 159.43 KB | Crell |
Comments
Comment #1
Dries CreditAttribution: Dries commentedLooks a little funny already:
Comment #2
Crell CreditAttribution: Crell commentedD'Oh! That's because system.module is the only module that already had a page file, so I don't need to add it to the Entries file. Take 2!
Comment #3
Crell CreditAttribution: Crell commentedRerolling to keep up with head.
Comment #4
Crell CreditAttribution: Crell commentedRerolling, and this version also splits off theme functions as well per conversation with merlinofchaos and pwolanin. Total savings, over 50%!
Comment #5
pwolanin CreditAttribution: pwolanin commentedLooks good , once I figured out how to get a menu rebuild to happen (edit & save a content type, if you're not using Devel module).
All pages and functions work as expected.
Comment #6
Dries CreditAttribution: Dries commentedLooks like this patch needs a quick re-roll.
Comment #7
Crell CreditAttribution: Crell commentedCNW until I have a chance to reroll it for the block caching patch...
Comment #8
Crell CreditAttribution: Crell commentedAnother advantage of splitting Drupal up into smaller files is that there's hopefully less chance of patches bumping into each other, at least as far as CVS is concerned. *sigh*
Comment #9
Caleb G2 CreditAttribution: Caleb G2 commentedI guess there's a larger problem here. Patch #25 does the same thing the patch I tried to re-roll did (never posted it since it didn't work) -- after applying the patch and running the installer Drupal gives WSOD.
Comment #10
pwolanin CreditAttribution: pwolanin commented@CalebG - Are you installing form scratch, or using an existing install? If the latter, did you rebuild your {menu_router}?
Comment #11
Caleb G2 CreditAttribution: Caleb G2 commentedpwolanin: From scratch (fresh check out of head)
Comment #12
Crell CreditAttribution: Crell commentedCalebG: Did you apply the patch before you ran the install or after? If after, you will need to put menu_rebuild() in your index.php right before the menu_execute_active_item() call and load the main page once to refresh the menu.
Comment #13
Caleb G2 CreditAttribution: Caleb G2 commentedSheesh guys - come on! What kind of goofball do you think I am?!
Of course, I applied the patch beforehand. :)
Comment #14
Crell CreditAttribution: Crell commentedSorry, Caleb, I was reading quickly and didn't quite realize the illogic of my question. :-)
Found the problem, though. The installer uses _system_zonelist(), which had previously been moved to the admin pages file. Attached version doesn't move it. Of course, that means it's not strictly an internal function and should not be an underscore function, but I'm not going to worry about that in this patch. :-)
Comment #15
asimmonds CreditAttribution: asimmonds commentedA fresh install from scratch seems to work fine now.
Going to admin/build/themes, generates a error that the theme function 'theme_themes_form()' can not be found, should this be theme_system_themes_form() ?
Comment #16
Crell CreditAttribution: Crell commentedWhy yes. Yes it should. :-) Rerolled, fixes #15.
Comment #17
pwolanin CreditAttribution: pwolanin commentedgoing to the module uninstall page I get this error:
Comment #18
pwolanin CreditAttribution: pwolanin commentedlooks like a typo in system_theme()
Comment #19
pwolanin CreditAttribution: pwolanin commentedmaybe we should get this one in ASAP: http://drupal.org/node/168028 so we can alleviate the need to put in all the function names...
Comment #20
pwolanin CreditAttribution: pwolanin commentedHere's a re-roll taking advantage of the fact that the patch I linked above was committed.
Now all the theme functions seem to work.
Comment #21
Dries CreditAttribution: Dries commentedTested, seems to work. Thanks.
Comment #22
(not verified) CreditAttribution: commented