This issue is split off from #1260800: Kill the overlay for widths below 640 pixels with the idea being that this may be a D7-backportable approach to solving the problem that the overlay does not work well on many mobile devices.

The idea (described in more detail in the issue above) is that when a user is on a mobile device, we should give them an easy way to disable the overlay if they so choose (reusing the same method we currently have for screen reader users and keyboard-only users).

Screenshot at http://drupal.org/files/overlay-dismiss-message-small-screen.png

The internals of the Drupal.checkWidthBreakpoint() function introduced here will depend on what's being discussed in the other issue also.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

Issue tags: +JavaScript

tag.

nod_’s picture

Status: Needs review » Needs work

The checkbrekpoint thing has been committed, this needs reroll.

nod_’s picture

Version: 8.x-dev » 7.x-dev
Issue summary: View changes

Overlay is dead to D8 #2088121: Remove Overlay.

jenlampton’s picture

I don't think this is the right way to go here.

My user's don't want to opt out of using the overlay permanently. They only want to opt-out of using it while on a mobile device. If they go back to the site on a computer tomorrow, I don't want them to have to turn the overlay back ON. And then OFF again the next time they are on a phone. You see the problem.

I don't think this is an acceptable solution for D7. We need to just disable the thing (automatically) on mobile.

I'm currently using this patch (adapted from #26 on the previous issue. It works great on my D7 sites (I don't have any overlay-generated URLs to worry about). It would be great to see a broader soliton that took the overlay urls and redirected them back to their non-overlay equivalents, can this be done in JS?

nod_’s picture

Issue tags: -Needs backport to D7

Should be possible, no interest in working on it though.

jenlampton’s picture

Status: Needs work » Needs review

Patch still applies cleanly to 7.52. I've been running this patch in production for nearly 3 years now with no issues.

Status: Needs review » Needs work

The last submitted patch, 4: core-js-overlay-width-1655098-4.patch, failed testing.