Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Steps to reproduce:
- create boolean field on a node content type
- enter some 'help text' (description)
- use 'single on/off checkbox' as the widget
Expected:
- checkbox & help text display on the node edit page
Actual:
- help text displays, but the checkbox is nowhere to be found; not present in markup, so it's not a CSS issue; disabling JS does not help
Some checkboxes on edit-node pages do not get displayed.
Comment | File | Size | Author |
---|---|---|---|
#16 | 1649392-bootstrap-checkbox_radio_title_fix-16.patch | 929 bytes | markhalliwell |
#11 | bootstrap-single-value-checkboxes-1649392-11.patch | 871 bytes | markhalliwell |
#3 | 1649392-checkbox_not_rendered-3.patch | 538 bytes | yuriy.babenko |
#2 | 1649392-checkbox_not_rendered-2.txt | 538 bytes | yuriy.babenko |
#1 | 1649392-checkbox_not_rendered-1.patch | 539 bytes | yuriy.babenko |
Comments
Comment #1
yuriy.babenko CreditAttribution: yuriy.babenko commentedBug is in
twitter_bootstrap_form_element()
. Patch attached. (Disclaimer: minimal testing done.)Comment #2
yuriy.babenko CreditAttribution: yuriy.babenko commentedMade a typo in the patch above. Corrected version attached.
Comment #3
yuriy.babenko CreditAttribution: yuriy.babenko commented... and here's one with the proper file extension!
Comment #4
wundo CreditAttribution: wundo commentedThis patch breaks the display for multi value checkboxes.
Comment #5
gagarine CreditAttribution: gagarine commentedComment #6
natted CreditAttribution: natted commentedI just tried to replicate this issue... but so far when I follow the steps, I do see a checkbox.
Have I missed something?
Comment #7
andregriffin CreditAttribution: andregriffin commentedComment #8
wundo CreditAttribution: wundo commentedMoving back to the original project
Comment #9
natted CreditAttribution: natted commentedComment #10
markhalliwellI was able to reproduce this via #1947214: Problems on revision tab. @wundo can you please explain #4? I don't see how this breaks, maybe it doesn't since the form stuff seems to have been refactored since this issue was opened. Applying #3 outputs the same structure of markup for both checkboxes and radios. Looks good to me:
Comment #11
markhalliwellRe-rolled patched against latest dev
Comment #12
markhalliwell@wundo please review.
Comment #13
wundo CreditAttribution: wundo commentedI'm unable to reproduce it on my local environment, #description works perfect to me
Comment #14
wundo CreditAttribution: wundo commentedGuys, I can't reproduce this on my local using the following checkbox:
Could you clarify how to reproduce this using plain FAPI elements?
Comment #15
wundo CreditAttribution: wundo commentedComment #16
markhalliwellOk, I was able to reproduce the original issue, which is the same issue that was happening in #1947214: Problems on revision tab.
It has to do with the fact the the "On value" title is empty (ie: boolean). There is a checkbox on the field configuration page underneath the help text, that if checked, will allow the checkbox to be shown then:
I actually agree with @wundo in #4 though now. The element output needs to be in
$variables['#children']
not the standard$output
like the others. The issue really lies in how the label is processed.Comment #17
WorldFallz CreditAttribution: WorldFallz commentedi can confirm patch in #16 fixes the issue for me.
The easiest way to reproduce this bug is to:
So far I don't see any other ill effects-- will continue to test with the patch applied.
Comment #18
markhalliwellI'm marking this rtbc then.
Comment #19
markhalliwellThanks!
7.x-2.x - Committed cb42e88
7.x-3.x - Committed 10ad334
Comment #21
markhalliwell