Title says it all.

CommentFileSizeAuthor
#6 1637448-4.patch1.75 KBdamiankloip
ctools-exportable-no-return.patch768 bytesdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Issue tags: +VDC

.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Sure the fixes looks fine though some tests would be important.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

I was going to have tests on the issues for those methods (#1637640: createDuplicate() method on ExportableControllerBase won't work is one). You think have some here too?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

I think this is okay for the moment, but sure it would be always nice to have that.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

I think this is okay for the moment, but sure it would be always nice to have that.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
1637448-4.patch1.75 KB

Exportables are being put on hold for now, a couple of tests for duplicates in this patch. Just checking it passes for testbot.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs review » Fixed

Committed, http://drupalcode.org/project/ctools.git/commit/54f3e35

Automatically closed -- issue fixed for 2 weeks with no activity.