Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Move the Handler tests to PSR-0. This is for 8.x-3.x.
Comment | File | Size | Author |
---|---|---|---|
#9 | views-1637412-8.patch | 19.26 KB | Manuel Garcia |
#7 | views-1637412-7.patch | 85.94 KB | Manuel Garcia |
handlers.patch | 17.63 KB | RobLoach | |
Comments
Comment #1
aspilicious CreditAttribution: aspilicious commentedLooks good someone needs to verify these tests are selectable and come back green
Comment #2
aspilicious CreditAttribution: aspilicious commentedComment #3
Manuel Garcia CreditAttribution: Manuel Garcia commentedPatch applies cleanly
However, after clearing the cache, visiting the tests page gets you a WSOD. Here's the apache error.log
Comment #4
aspilicious CreditAttribution: aspilicious commentedYeah the info file needs a cleanup ;)
Comment #5
dawehnerNow the testbot should come in
Comment #6
dawehnerhandlers.patch queued for re-testing.
Comment #7
Manuel Garcia CreditAttribution: Manuel Garcia commentedHere's the updated patch with the info file cleanup.
I then ran all views handlers tests:
Area: text: 5 passes, 0 fails, 0 exceptions, and 1 debug message OK
Argument: Null: 5 passes, 0 fails, 0 exceptions, and 2 debug messages OK
Argument: String: 1 pass, 18 fails, and 1 exception BROKEN:
Class 'Drupal\views\Tests\Handler\view' not found PHP Fatal error file:ArgumentStringTest.php Line 63 Function: Unknow
Comment #8
aspilicious CreditAttribution: aspilicious commentedYou're misisng the new files
Comment #9
Manuel Garcia CreditAttribution: Manuel Garcia commentedOK, after input from aspilicious in IRC, we had to put use view; in the failing tests.
I reran all tests, and fixed those that exploded.
Comment #10
dawehneryeeaaah the first patch is in!
Comment #11
RobLoachComment #12
tim.plunkett