Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Version: 7.x-3.x-dev » 8.x-3.x-dev

.

amateescu’s picture

Version: 8.x-3.x-dev » 7.x-3.x-dev
Status: Active » Needs review
Issue tags: +VDC
FileSize
66 KB

First try, didn't run the tests locally.

Status: Needs review » Needs work

The last submitted patch, 1636864-view_object_psr0.patch, failed testing.

merlinofchaos’s picture

Version: 7.x-3.x-dev » 8.x-3.x-dev
amateescu’s picture

Status: Needs work » Needs review
amateescu’s picture

Issue tags: -VDC

#2: 1636864-view_object_psr0.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, 1636864-view_object_psr0.patch, failed testing.

amateescu’s picture

FileSize
66 KB

.

amateescu’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, view_object_psr0-2.patch, failed testing.

amateescu’s picture

Status: Needs work » Needs review
FileSize
73.34 KB

Some progress.

Status: Needs review » Needs work

The last submitted patch, view_object_psr0-3.patch, failed testing.

amateescu’s picture

Status: Needs work » Needs review
FileSize
74.58 KB

Status: Needs review » Needs work

The last submitted patch, view_object_psr0-4.patch, failed testing.

dawehner’s picture

Just some small things i found.

If you review this patch please ignore the moved classes for the moment.

+++ b/lib/Drupal/views/View.phpundefined
@@ -2,21 +2,18 @@
+ * Definition of Drupal\views\view.

So i'm wondering whether it should be Drupal\views\View instead?

+++ b/lib/Drupal/views/View.phpundefined
@@ -2,21 +2,18 @@
-/**
- * @defgroup views_objects Objects that represent a View or part of a view
- * @{
- * These objects are the core of Views do the bulk of the direction and
- * storing of data. All database activity is in these objects.

Seems to be a bit odd to remove existing documentation.

+++ b/lib/Drupal/views/ViewsDbObject.phpundefined
@@ -0,0 +1,410 @@
+ * Definition of Drupal\views\views_db_object.

A bit odd as well...

aspilicious’s picture

+++ b/lib/Drupal/views/View.phpundefined
@@ -2,21 +2,18 @@
+use Drupal\views\ViewsDbObject;

don't need to do that when we are in the same namespace

amateescu’s picture

Status: Needs work » Needs review
FileSize
78.28 KB

Fixed #15 1) 3) and #16. About #15 2) I guess the documentation needs to be reviewed (and completed) anyway and I didn't think there was much value in that specific doxygen block in order to keep it.

Let's see how this one goes, it contains a lot more changes and some small fixes for the new UiSettingsTest which was failing for me locally.

Status: Needs review » Needs work

The last submitted patch, view_object_psr0-7.patch, failed testing.

amateescu’s picture

Status: Needs work » Needs review
FileSize
79.63 KB

Status: Needs review » Needs work

The last submitted patch, view_object_psr0-8.patch, failed testing.

amateescu’s picture

Status: Needs work » Needs review
FileSize
80.09 KB

Status: Needs review » Needs work

The last submitted patch, view_object_psr0-9.patch, failed testing.

aspilicious’s picture

Status: Needs work » Needs review

.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

This will conflict with https://drupal.org/node/1637552
Lets commit this (but don't forget to change the line from the previous issue)

dawehner’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/tests/views_analyze.testundefined
@@ -18,12 +18,12 @@ class ViewsAnalyzeTest extends ViewsSqlTest {
+    parent::setUp();
+//    module_enable(array('views_ui'));
     // @TODO Figure out why it's required to clear the cache here.
-    views_module_include('views_default', TRUE);
-    views_get_all_views(TRUE);
-    menu_router_rebuild();
+//    views_module_include('views_default', TRUE);
+//    views_get_all_views(TRUE);

Maybe you could explain that a bit, why this is required

+++ b/tests/views_upgrade.testundefined
@@ -175,7 +177,7 @@ class ViewsUpgradeTestCase extends ViewsSqlTest {
+      $view = new Drupal\views\View();

Just wondering why not use just new View();

+++ b/views.api.phpundefined
@@ -660,7 +660,7 @@ function hook_views_api() {
+  $view = new Drupal\views\View();

.

aspilicious’s picture

The last is correct, thats a api.php file.

amateescu’s picture

Status: Needs work » Needs review
FileSize
79.63 KB

Discussed #25 with @dawehner:
1) this is not really required, it's just a little clean-up for that test. In the attached patch, the unneeded lines are removed, not only commented.
2) this is because ctools exportables need to instantiate the full namespaced object, because they can't export use statements.
3) as @aspilicious said, this is correct :)

Re-rolled the patch because it was kinda broken by all the test conversions that were committed in the meantime.

Status: Needs review » Needs work

The last submitted patch, view_object_psr0-10.patch, failed testing.

dawehner’s picture

Status: Needs work » Fixed

Did some manual testing in the ui and still everything worked so lets get this in.

Huge thanks for this big converting patch!

Automatically closed -- issue fixed for 2 weeks with no activity.