Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
First issue from the VDC sprint in Barcelona :)
Comment | File | Size | Author |
---|---|---|---|
#27 | view_object_psr0-10.patch | 79.63 KB | amateescu |
#21 | view_object_psr0-9.patch | 80.09 KB | amateescu |
#19 | view_object_psr0-8.patch | 79.63 KB | amateescu |
#17 | view_object_psr0-7.patch | 78.28 KB | amateescu |
#13 | view_object_psr0-4.patch | 74.58 KB | amateescu |
Comments
Comment #1
dawehner.
Comment #2
amateescu CreditAttribution: amateescu commentedFirst try, didn't run the tests locally.
Comment #4
merlinofchaos CreditAttribution: merlinofchaos commentedComment #5
amateescu CreditAttribution: amateescu commentedComment #6
amateescu CreditAttribution: amateescu commented#2: 1636864-view_object_psr0.patch queued for re-testing.
Comment #8
amateescu CreditAttribution: amateescu commented.
Comment #9
amateescu CreditAttribution: amateescu commentedComment #11
amateescu CreditAttribution: amateescu commentedSome progress.
Comment #13
amateescu CreditAttribution: amateescu commentedComment #15
dawehnerJust some small things i found.
If you review this patch please ignore the moved classes for the moment.
So i'm wondering whether it should be Drupal\views\View instead?
Seems to be a bit odd to remove existing documentation.
A bit odd as well...
Comment #16
aspilicious CreditAttribution: aspilicious commenteddon't need to do that when we are in the same namespace
Comment #17
amateescu CreditAttribution: amateescu commentedFixed #15 1) 3) and #16. About #15 2) I guess the documentation needs to be reviewed (and completed) anyway and I didn't think there was much value in that specific doxygen block in order to keep it.
Let's see how this one goes, it contains a lot more changes and some small fixes for the new UiSettingsTest which was failing for me locally.
Comment #19
amateescu CreditAttribution: amateescu commentedComment #21
amateescu CreditAttribution: amateescu commentedComment #23
aspilicious CreditAttribution: aspilicious commented.
Comment #24
aspilicious CreditAttribution: aspilicious commentedThis will conflict with https://drupal.org/node/1637552
Lets commit this (but don't forget to change the line from the previous issue)
Comment #25
dawehnerMaybe you could explain that a bit, why this is required
Just wondering why not use just new View();
.
Comment #26
aspilicious CreditAttribution: aspilicious commentedThe last is correct, thats a api.php file.
Comment #27
amateescu CreditAttribution: amateescu commentedDiscussed #25 with @dawehner:
1) this is not really required, it's just a little clean-up for that test. In the attached patch, the unneeded lines are removed, not only commented.
2) this is because ctools exportables need to instantiate the full namespaced object, because they can't export
use
statements.3) as @aspilicious said, this is correct :)
Re-rolled the patch because it was kinda broken by all the test conversions that were committed in the meantime.
Comment #29
dawehnerDid some manual testing in the ui and still everything worked so lets get this in.
Huge thanks for this big converting patch!