The same node is listed multiple times in the "My Edits" list:
My Edits

#5 workbench-my_views_duplicates-1630702-5.patch18.76 KBkbentham
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View
workbench_dupes_my_edits.png34.01 KBtsvenson
Members fund testing for the Drupal project. Drupal Association Learn more


barraponto’s picture

Are they different nodes? I faced a similar issue with overlay + rules duplicating nodes and polluting my views, including workbench.

tsvenson’s picture

Its the same node.

barraponto’s picture

OK, upon closer look, that view lists revisions (not nodes), therefore it is supposed to display the same node several times if it has been edited several times. In order to further debug, try adding the "Content revision: Vid" field. Each row should have a different vid (meaning a different revision). If you want to check what changed in each revision, try the Diff module.

The "Last updated" field is confusing, though. It might seem that it refers to when that revision was created, but that's not the case: it actually says when the node was last updated. That's why they all show the same date, since they're edits to the same node.

I suggest ditching the "Content: updated date" field for "Content revision: updated date", since it would be more useful. Also, there's no need for "Action Links" (it just doesn't work) and "Revised by" (this is the "My edits" view, the value here will always be the same => the logged in user).

kbentham’s picture

Status: Active » Needs review

This patch should take care of at least some of the confusion with the duplicates. I have changed the title so it will now display the title of the revision as well as link to the revision instead of just the node. The "Last updated" now displays the update date of the revision instead of the node and I have also removed "Revised by".

kbentham’s picture

18.76 KB
PASSED: [[SimpleTest]]: [MySQL] 0 pass(es). View

It would be helpful if I actually uploaded the patch.

stevector’s picture

Status: Needs review » Fixed

Since the edit link is broken: #1388220: Actions Missing in My Edits, I'm committing a version that just removes that actions column. That can be resolved separately in the other issue.

barraponto’s picture

What about the "revised by" column? When we're lookin at the "my reviews" table, I assume they're all mine, right? No need for that column.

kbentham’s picture

Yes because all of the item in the table were revised by the user looking at them it was a little redundant.

brunodbo’s picture

Would it make sense to filter the 'My edits' view by 'Workbench moderation: Current revision'? Might clear things up more for editor users. We could add a link to 'node/%nid/moderate' to every views row, to point users to other revisions if they need them.

brunodbo’s picture

Nevermind: making the change suggested in #9 depends on having WB moderation intstalled ...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Voroz’s picture

Patch wokrs fine for me, but it remains an issue in My Drafts: The title is still the node's title instead of the revision title.

barraponto’s picture

Status: Closed (fixed) » Needs work

Then we're back to needs work.

hass’s picture

rv0’s picture

I can confirm #14 fixes it for me.

agentrickard’s picture

Status: Needs work » Closed (fixed)

Closing again in favor of the other issue.

agentrickard’s picture

Issue summary: View changes

Used the a tag instead of img...