"My Drafts" tab should not list published content [#1630682]

When clicking on the My Drafts tab in My Workbench, I expect to get a list of my content that is in draft state. However, default is to list all my content:

As seen in the screenshot both drafts and published nodes are listed. What makes it even weirder is that the State option in the exposed Views filter only allow me to chose between Draft and Needs Review.

Comment	File	Size	Author
#9	workbench_moderation_1630682+My+Drafts+tab+should+not+list+published+content.patch	3.95 KB	hass
#9
#6	workbench_moderation_1630682+My+Drafts+tab+should+not+list+published+content_1781744_followup.txt	23.81 KB	hass
#3	skitch.png	53.94 KB	operinko
	workbench_moderation_my_drafts.png	28.22 KB	tsvenson

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

hass CreditAttribution: hass commented 23 September 2012 at 00:12

The difficulty here may be that the states are not hardcoded states. A site may not have a Draft state... However confusing this is...

Comment #2

webkomplize CreditAttribution: webkomplize commented 21 October 2012 at 12:45

Any solution for this? Is really confusing.

Comment #3

operinko CreditAttribution: operinko commented 28 November 2012 at 08:11

File	Size
skitch.png	53.94 KB

I've also noticed a similar issue.
1) Published items are shown on the "My Drafts" tab.
2) Some "Draft"s don't have a Moderation history, title or type.
- This only happens on nodes that have already gone through the moderation workflow (from Draft -> Published) and then get a new draft created.

Any ideas? It seems to me that this is an issue with the view configuration.

Comment #4

hass CreditAttribution: hass commented 28 November 2012 at 08:40

#1781744: Draft and Needs review pages are broken may fixed this issue.

Comment #5

hass CreditAttribution: hass commented 12 January 2013 at 18:53

Assigned:

Unassigned

It's a quite easy to remove the unpublished nodes, but creating a patch before #1781744: Draft and Needs review pages are broken has been committed is difficult. I'm waiting for the commit and create a patch afterwards.

Until this happened:

Go into the Drafts Page view
Add a filter criteria
Check Workbench Moderation: State
Apply (this display)
Apply and continue
Select operator Is not one of and check Moderation Status Published
Rearange Workbench Moderation: State <> Published to 3rd postion
Save all

We can export this and create a patch, but it would invalidate all other patches now.

Comment #6

hass CreditAttribution: hass commented 12 January 2013 at 18:56

File	Size
workbench_moderation_1630682+My+Drafts+tab+should+not+list+published+content_1781744_followup.txt	23.81 KB

Here is the export

Comment #7

hass CreditAttribution: hass commented 12 January 2013 at 19:12

Priority:

Normal

» Critical

Let's mark this critical for release so we have a chance to get a more properly working Workbench Moderation module for the very first time.

Comment #8

hass CreditAttribution: hass commented 14 January 2013 at 17:46

Issue tags:

+Workbench Sprint

Comment #9

hass CreditAttribution: hass commented 16 January 2013 at 18:44

Status:

Active

» Needs review

File	Size
workbench_moderation_1630682+My+Drafts+tab+should+not+list+published+content.patch	3.95 KB

This works well for me and just lists all nodes that are not published. This may not 100% perfect since a Needs review is not really a Draft how the tab itself may tell us, but it is a good compromise and we don't have a Needs review tab... so all is good from my point of view :-).