Replace language() with Drupal::language().

We were playing with the idea of a drupal($service) function that would retrieve the desired service.

  function drupal($service) {
    return drupal_container()->get($service);
  }

  $language_interface = drupal(LANGUAGE_TYPE_INTERFACE);

But, in the end, a wrapper function is just a wrapper function. It doesn't actually help you architecturally. For that reason, we've been focusing on getting the objects in there first, and worrying about minuet micro-syntax-optimizations like that later. We don't want to be STUPID ;-) .

Regarding the language system, the end goal is to move drupal_language_initialize() to a LanguageSystem class, and a "language" service. This means that there would not be a language bootstrap as the entire language system would be lazy-loaded the first time you try to use it. I believe that's at #1550866: Remove obsolete drupal_language_initialize().

Can we close this in light of #2001206: Replace drupal_container() with Drupal::service()?

Wow, that's an old issue ;)

This changed a lot already, we have the language() function now, which we should move to the Drupal class as it's a "service-exposing" function.

Getting weird test errors here that are a bit beyond me. Let's see how this goes with the testbot while I continue to hack away.

Woops, missing a namespacing.

+++ b/core/lib/Drupal/Core/Condition/ConditionManager.phpundefined
@@ -33,7 +33,7 @@ public function __construct(\Traversable $namespaces) {
-    $this->discovery = new CacheDecorator($this->discovery, 'condition:' . language(Language::TYPE_INTERFACE)->langcode);
+    $this->discovery = new CacheDecorator($this->discovery, 'condition:' . Drupal::language(Language::TYPE_INTERFACE)->langcode);

You need to use \Drupal in classes.

Thanks ack - hopefully I got them all.

#10: 1630050-replace_language_drupal_language-10.patch queued for re-testing.

+++ b/core/lib/Drupal.phpundefined
@@ -195,6 +195,26 @@ public static function keyValueExpirable($collection) {
+  public static function language($type) {
+    if (!static::$container->has('language_manager')) {
+      // This happens in rare situations when the container has not been built by
+      // a kernel and has no services, e.g., when t() is called during unit tests
+      // for assertions.
+      static::$container->register('language_manager', 'Drupal\Core\Language\LanguageManager');
+    }
+    return static::$container->get('language_manager')->getLanguage($type);

We might be able to move the service registration into the CoreBundle. There might be instances where we can't do this though. Let's see what the test bot says.

#14: 1630050.patch queued for re-testing.

#10: 1630050-replace_language_drupal_language-10.patch queued for re-testing.

#14: 1630050.patch queued for re-testing.

language() is gone, closing.