Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When you entered the database variables and then go the 'Configure site' section on the installer page, you get 2 php notices (Notice: Undefined index: pass in /home/projects/drupal6/install.php on line 148) when you have not supplied a password for your database connection. In my case, I tested it on my localhost with the root user without a password. This probably won't happen a lot, but I've added a patch which takes care of this notice.
Comment | File | Size | Author |
---|---|---|---|
#1 | install_notice_0.patch | 8.65 KB | kkaefer |
install_notice.patch | 1.56 KB | swentel | |
Comments
Comment #1
kkaefer CreditAttribution: kkaefer commentedObviously, parse_url() doesn't always return all indices. To prevent such E_NOTICEs in general, we want a function that makes sure that all indices are there, even if they might be empty.
Comment #2
swentel CreditAttribution: swentel commentedWow, great patch, *much* better than mine. Applied it on a fresh install and notices about the not defined pass index are gone, so I've marked the status to RTBC. I think all notices are gone now in the installer, except my other report on http://drupal.org/node/162824 .
Comment #3
Dries CreditAttribution: Dries commentedThis looks OK, but we'll want to document why we merge with an "empty" array. People that aren't aware of E_NOTICE might find this code weird ...
Comment #4
Dries CreditAttribution: Dries commentedNeeds some more code comments, and needs a reroll against CVS HEAD.
Comment #5
blackdog CreditAttribution: blackdog commentedI have my PHP settings to show all errors, making installing HEAD impossible, since the 'pass' notice makes the installer put out this message:
Allthough one shouldn't use error_reporting E-ALL on a production box, it's quite common for development.
The above patch doesn't apply to HEAD.
Comment #6
dpearcefl CreditAttribution: dpearcefl commentedIs this still a problem in current D6?
Comment #7
dpearcefl CreditAttribution: dpearcefl commented