I'm not sure if you want to customise the exports, but not all installations have filter format of ID 1.

-  $handler->display->display_options['empty']['area']['format'] = '1';- 
+ $handler->display->display_options['empty']['area']['format'] = variable_get('filter_default_format', 1);
Members fund testing for the Drupal project. Drupal Association Learn more


Cottser’s picture

Title: Default view relies on a text format with ID 1 (views/feeds.views_default.inc) » Update default views (fixes "Missing text format: 1." in watchdog)
15.12 KB

Format IDs are no longer numeric in Drupal 7 (#934050: Change format into string). I think the default views should be updated anyway since Views is no longer in alpha - arguments are contextual filters now, for example. I re-exported the default views (running Views 7.x-3.3), and removed the text format of 1 from the revised export (Views can figure out the format). I didn't do any other massaging of the exported view other than adding a human name of "Feeds log".

This export also adds items to the $translatables array, that seems to be new as well.

Cottser’s picture

Actually, without this change, the empty text is not displayed at all when visiting node/%/log - so it's not just a watchdog error.

Mathijs Koenraadt’s picture

Status: Needs review » Reviewed & tested by the community

Patch makes sense.

Do we also need a .install file update_N() routine to update the views?

JvE’s picture

Status: Reviewed & tested by the community » Needs review
21.73 KB

The $translatables is a Features thing, not a views export thing.

There are some other changes between views-3.0-alpha1 and views-3.0. If we're changing the version, I think we should take those along as well.
If you take the current feeds_log view and open/save every item/setting and then export the view, it shows a couple more differences.

Cottser’s picture

Status: Needs review » Reviewed & tested by the community
10.67 KB
11.87 KB

Thanks @JvE. The patch looks good, I tested it using the minimal install profile.

  1. Enable Feeds UI, Views UI, and all dependencies.
  2. Create a standalone Feeds importer.
  3. Navigate to the “Log” tab of the Feeds importer you just created.

Without the patch, no empty text is shown and a watchdog error is logged. After applying the patch and clearing the cache, the empty text is shown and there are no watchdog errors.



twistor’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.