There is some velocity part in the current solrconfig that crashes when used with war files and tomcat (not sure about jetty)

This should be removed from the code as it does not serve any purpose

CommentFileSizeAuthor
#8 remove-velocity-1612556-8.patch2.2 KBcpliakas
#1 1612556-1.patch4.44 KBNick_vh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
FileSize
1612556-1.patch4.44 KB
Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented
Status: Active » Needs review
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
Status: Needs review » Reviewed & tested by the community 
+++ b/conf/3.x/solrconfig.xml
@@ -1542,15 +1468,7 @@
-  
-
+    ¶

Trailing whitespace.

As is often the case, I have no idea what the effect or purpose of this is. It isn't in the Search API config, though, so I for one can certainly live without it.

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented

Thanks guys. Regarding #1612556-1: Velocity not needed in solrconfig, would you guys be opposed to commenting out the various configs rather than deleting them? I feel it would make it a little easier to maintain going forward, as it will be easier to see the differences between configs going forward. In addition, it will make it more transparent about what we are not using without having to go through the git logs.

Nick_vh’s picture

Nick_vh
he/him
Location Ghent
CreditAttribution: Nick_vh commented

Sure, you can comment it out. :-)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented

Yes, I'd be fine with that. Maybe a small comment could, at least in the more interesting cases, even explain why things are commented out.

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented

+1 to #1612556-6: Velocity not needed in solrconfig, even if the comment just points to the issue discussing the change.

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
FileSize
remove-velocity-1612556-8.patch2.2 KB

Patch attached with changes suggested in #1612556-4: Velocity not needed in solrconfig and #1612556-6: Velocity not needed in solrconfig.

cpliakas’s picture

cpliakas CreditAttribution: cpliakas commented
Status: Reviewed & tested by the community » Fixed

Committed at http://drupalcode.org/sandbox/cpliakas/1600962.git/commit/1ec5d27.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

amontero’s picture

amontero
Location Barcelona
CreditAttribution: amontero commented
Issue summary: View changes
Issue tags: +solrconfig.xml
Related issues: +#2428093: Update provided Solr 4.x solrconfig.xml

Any pointer of which is exactly what triggers the Tomcat crash? Is there any issue or steps to reproduce the crash?
As the issue 2 years old, perhaps it's currently fixed and Velocity can be reenabled. It's a nice UI worth having and I will happily check it and update the config.
Tagging and linking to #2428093: Update provided Solr 4.x solrconfig.xml