I think settings should be passed locally to Drupal's JavaScript behaviors rather than using the global Drupal.settings variable.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

aheredia’s picture

This is the patch

aheredia’s picture

Status: Active » Needs review
arshadcn’s picture

Status: Needs review » Postponed (maintainer needs more info)

Thanks. Any reason against using Drupal.settings?

aheredia’s picture

It's commented in Managing JavaScript in Drupal 7.

It's a change made in drupal api 7 Converting 6.x modules to 7.x

Greetings

arshadcn’s picture

Status: Postponed (maintainer needs more info) » Needs work

Thanks

Dave Reid’s picture

Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs work » Fixed

Re-rolled and committed #1 to 7.x-2.x. http://drupalcode.org/project/chosen.git/commit/55ba20f

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.