I think settings should be passed locally to Drupal's JavaScript behaviors rather than using the global Drupal.settings variable.

CommentFileSizeAuthor
#1 chosen-settings_behavior-1609036-1.patch1.05 KBaheredia
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aheredia’s picture

aheredia CreditAttribution: aheredia commented
FileSize
chosen-settings_behavior-1609036-1.patch1.05 KB

This is the patch

aheredia’s picture

aheredia CreditAttribution: aheredia commented
Status: Active » Needs review
shadcn’s picture

shadcn CreditAttribution: shadcn commented
Status: Needs review » Postponed (maintainer needs more info)

Thanks. Any reason against using Drupal.settings?

aheredia’s picture

aheredia CreditAttribution: aheredia commented

It's commented in Managing JavaScript in Drupal 7.

It's a change made in drupal api 7 Converting 6.x modules to 7.x

Greetings

shadcn’s picture

shadcn CreditAttribution: shadcn commented
Status: Postponed (maintainer needs more info) » Needs work

Thanks

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs work » Fixed

Re-rolled and committed #1 to 7.x-2.x. http://drupalcode.org/project/chosen.git/commit/55ba20f

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.