http://drupal.org/project/video

Problem/Motivation

For HTML elements with a src attribute, such as video, or a data attribute, such as object, the microdata attributes have to be placed within the element itself. This means that microdata module will need to pass the microdata attributes to the templates, which are placed in sites/all/modules/video/theme.

Proposed resolution

  1. Add the property information that is required by Entity API. Properties should potentially include some metadata. For example, http://schema.org/VideoObject exposes the encodingFormat (i.e. mpeg4)
  2. Use hook_microdata_value_types_alter(&$types) to change the value type to 'item_option'.
  3. Figure out how to get microdata attributes from the formatter code to the template and place it on the video tag.
  4. If metadata is included, add that to the templates in meta tags, conditional on whether microdata exists for them.
  5. Add a suggested mapping based on Schema.org

Remaining tasks

Everything ;)

User interface changes

Microdata box and suggestions radio will be added to the bottom of the field settings page.

Files: 
CommentFileSizeAuthor
#1 1606580-1-video_microdata.patch4.2 KBcolette
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1606580-1-video_microdata.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

colette’s picture

StatusFileSize
new4.2 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1606580-1-video_microdata.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

I wrote the first patch for the video module, publishing microdata for the URL and thumbnail of the video.

colette’s picture

Project:Microdata» Video

I moved the issue to the Video module queue.

colette’s picture

Assigned:collette» colette
Status:Active» Needs review

I just realized that the issue was assigned to someone else, now it's fixed. I also switched the status to "needs review", waiting for some feedback from the module developers.

Status:Needs review» Needs work

The last submitted patch, 1606580-1-video_microdata.patch, failed testing.

Jorrit’s picture

Version:7.x-1.x-dev» 7.x-2.x-dev
Status:Needs work» Needs review

I'll take a look at it later, thanks for the patch. Let's see if it still applies to the most recent branch.

Jorrit’s picture

#1: 1606580-1-video_microdata.patch queued for re-testing.

Status:Needs review» Needs work

The last submitted patch, 1606580-1-video_microdata.patch, failed testing.

brycefisherfleig’s picture

Priority:Normal» Minor
Issue summary:View changes

Hi Colette,

Thanks for your contribution to this module! I'm not sure if you're still working on this issue, but it looks like the current patch probably just does not apply to the current head of video-7.x-2.x-dev. Could you try again to submit a patch? Let me know if I should unassign you from this issue instead. Thanks!

Cheers
Bryce

brycefisherfleig’s picture

Status:Needs work» Postponed